Re: [PATCH] drm/amdgpu: add missing NULL check

2023-10-09 Thread Samuel Pitoiset
I can confirm this patch fixes the kernel crash I reported. But as discussed with Christian, we should find the root cause. On 10/6/23 14:11, Christian König wrote: bo->tbo.resource can easily be NULL here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2

Re: [PATCH] drm/amdgpu: add missing NULL check

2023-10-09 Thread Christian König
Am 06.10.23 um 16:41 schrieb Alex Deucher: On Fri, Oct 6, 2023 at 9:07 AM Christian König wrote: bo->tbo.resource can easily be NULL here. Signed-off-by: Christian König Add a link to the bug report? Ah, crap. Forgotten to add the link before pushing that. But I've added a CC stable.

Re: [PATCH] drm/amdgpu: add missing NULL check

2023-10-06 Thread Alex Deucher
On Fri, Oct 6, 2023 at 9:07 AM Christian König wrote: > > bo->tbo.resource can easily be NULL here. > > Signed-off-by: Christian König Add a link to the bug report? With that: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- > 1 file changed, 1

[PATCH] drm/amdgpu: add missing NULL check

2023-10-06 Thread Christian König
bo->tbo.resource can easily be NULL here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h index

Re: [PATCH] drm/amdgpu: add missing NULL check in amdgpu_vm_update_mapping

2022-03-24 Thread philip yang
Reviewed-By: Philip Yang On 2022-03-24 4:13 a.m., Christian König wrote: The fence parameter is only optional. Signed-off-by: Christian König Fixes: 86fd5edfbdae ("drm/amdgpu: rework TLB flushing") --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 --- 1

[PATCH] drm/amdgpu: add missing NULL check in amdgpu_vm_update_mapping

2022-03-24 Thread Christian König
The fence parameter is only optional. Signed-off-by: Christian König Fixes: 86fd5edfbdae ("drm/amdgpu: rework TLB flushing") --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c