Ok.. here are my comments.. first lines of the diff and I already see something
wrong. Vivia said she didn't
notice it because she didn't think of 'clicking there'. I also just tried it
and I got a bug.
so, first, in gui.tcl, line 1768+ you add items to the menu for each user
allowing it to cha
You're right, in theory it makes perfect sens, but I don't think you're right
though about this because the default files are the ones
shipped with the skin and those are "your user's dps".. consider it as if
whenever you create a profile, we do a 'copy
skins/default/displaypics/* ~/.amsn/$prof
if {$email == "self"} {
+ set defaultfiles [glob -nocomplain -directory [file
join skins default displaypic] *.png]
+ set l [llength $defaultfiles]
set cachefiles [glob -nocomplain -directory [file
join $HOME display
Hi Vivia, Cristofaro, everyone else...
First, Cristofaro, sorry for not committing the patch earlier, I started
looking at it and didn't have time to
finish reviewing the code. I just starting looking at it again when I saw vivia
committed it already. So again,
sorry for the slow response from
Thanx, committed :)
On Mon, 8 Jan 2007, Cristofaro Del Prete wrote:
> Vivia Nikolaidou ha scritto:
> > It's OK, but since I committed your previous patch already, can you diff
> > against current SVN and resend it? :)
>
> I checked out amsn-devel before of amsn-commits... sorry
> Patch attache
Vivia Nikolaidou ha scritto:
> It's OK, but since I committed your previous patch already, can you diff
> against current SVN and resend it? :)
I checked out amsn-devel before of amsn-commits... sorry
Patch attached to message.
Index: utils/dpbrowser/dpbrowser.tcl
On Mon, 8 Jan 2007, Cristofaro Del Prete wrote:
> Vivia Nikolaidou ha scritto:
> >
> > Just two things: 1) Default DPs (the ones shipped with amsn) don't
> > show
>
> I fixed that in the 3rd patch attached to this message (I thought I
> already sent it to the ML, but looks like I didn't... sor
Vivia Nikolaidou ha scritto:
> Hi,
>
> I just tried your patch - Good work! (Y)
>
> Just two things: 1) Default DPs (the ones shipped with amsn) don't show
I fixed that in the 3rd patch attached to this message (I thought I
already sent it to the ML, but looks like I didn't... sorry)
> 2) The c
Hi,
I just tried your patch - Good work! (Y)
Just two things: 1) Default DPs (the ones shipped with amsn) don't show 2)
The camshooter button doesn't appear either
They should be easy enough, just that I don't have time to look at them
right now. However, I'll commit after I add the missing tr
