On Fri, Oct 31, 2008 at 06:10, <[EMAIL PROTECTED]> wrote:
> Branch: refs/heads/master
> Home: http://github.com/drf/amsn2
>
> Commit: b45c587c9e06768bd1fe6c5a541fc08fc2b86afa
> http://github.com/drf/amsn2/commit/b45c587c9e06768bd1fe6c5a541fc08fc2b86afa
> Author: Satanas <[EMAIL PROTECTED](none)>
> Date: 2008-10-30 (Thu, 30 Oct 2008)
>
> Changed paths:
> M amsn2/gui/front_ends/gtk/contact_list.py
> M amsn2/gui/front_ends/gtk/login.py
>
> Log Message:
> -----------
> [GTK] Showed contacts and groups by name
>
>
> Commit: 695e00ff6ce20a7c344e5427c187cbceccc4c53f
> http://github.com/drf/amsn2/commit/695e00ff6ce20a7c344e5427c187cbceccc4c53f
> Author: Satanas <[EMAIL PROTECTED](none)>
> Date: 2008-10-30 (Thu, 30 Oct 2008)
>
> Changed paths:
> M amsn2/gui/front_ends/gtk/contact_list.py
> M amsn2/gui/front_ends/gtk/image.py
> M amsn2/gui/front_ends/gtk/skins.py
>
> Log Message:
> -----------
> [GTK] Configured CL and showed DP
Hi!
Good job :)
I've got a few things to say.
Your image.py doesn't need loadFromEET since it's specific to efl.
Btw, we shouldn't use FIleObjects for files since we cannot use later
to display the file. We should save to disk. For the moment, using a
temporary file is good enough. Just move the code from
efl/image.py:loadFromFileObject to the
contactactlistmanager.py:onDPDownloaded and then use an Imageview with
a FileName.
I also think the skins stuff should be moved to gui/ and not be
defined by the front-end. Maybe only, the load function can be
front-end specific. The idea of key -> (type, data) should be kept.
Maybe (type, data) shouldn't be a tuple but a new object with those 2
attributes. This way, if you change this object somewhere, it'll be
change "everywhere" since it's just a reference. Then, if you have the
dp in the cl (with an emblem), and the dp alone elsewhere, if you load
the dp from a skin (for example you have: "Skin", "default_dp"), the
1st time you load it, you change it to ("PixBuf", smthg) and you won't
have to load it again from disk when you'll want to draw in the CL,
the CW, a properties window... I hope you'll understand my point and
why i added the ImageView thing instead of the simple image API for
each front-end.
I've started changing the whole profile.py but it shouldn't mean much
changes on the front-end side.
Ps: I'm off for the WE.
--
Boris FAURE (aka billiob)
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
