Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-31 Thread Youness Alaoui
Origato Sake, Your diff looks good, and I committed it as is in revision 8348. Thanks for the contribution! :) Are you done? or you still want to finish the other tasks ? Thanks! KKRT On Sat, Mar 31, 2007 at 03:39:07PM -0400, Sake Sashimi wrote: > Hi Kakaroto, > > I finished all the TODO regardi

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-28 Thread Youness Alaoui
Hi, Thanks Sake, About translation, it's really simple, all you have to do is : [trans translation_keyword] (for example [trans medium] and [trans small], etc..) then you open the file amsn/lang/langen (for english) and add the words in there, the keyword as the first of the line, so, for examp

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-22 Thread Youness Alaoui
hi, I just saw the email about the alarms, I answered it... I'll wait for this diff too, it seems to be going pretty well so far! thanks, KaKaRoTo On Thu, Mar 22, 2007 at 01:47:21PM -0400, Sake Sashimi wrote: > Hi Kakaroto, > > Thanks for your reply :) I guess I learn another lesson besides

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-21 Thread Youness Alaoui
Hi sake, I think your suggestion is good.. adding the size column and keeping the view->text size in the menu, but change its content from +1, +2, 0, -1, -2 into something more intuitive like "small, smallest, medium, large, largest" and have them as checkboxes so users can see which one is cu

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-21 Thread Youness Alaoui
Hi Alvaro, thanks for the answer, that's what I thought.. bad UI design from msn :p lool, I just checked and it still is "small/smaller/medium/big/bigger" (with 'smaller' selected by default:s) yes, it's not very good I think, so it would be better to just remove it.. I don't know what the UI gu

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-21 Thread Álvaro J. Iradier
It was added to mimic the behavior in the MSN Messenger. The text size was selected from the menu, as "Big, Normal, Small, ..." and that was +1, +0, -1, etc. from the default font. So, choosing a fixed size in the font dialog made no sense for me. Anyways, the font size is not sent to the destinat

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-20 Thread Youness Alaoui
Hi, thanks for the diff, I looked into the -nosizes option.. it was indeed added on purpose.. look here : http://amsn.svn.sourceforge.net/viewvc/amsn?view=rev&revision=2208 Which means that Alvaro added the option on purpose at revision 2208, on march 14th 2204 (3 years ago)... there was no spe

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-20 Thread Sake Sashimi
Hi Kakaroto and everyone, I went ahead and change the way user will choose font size from menu->text size as you have suggested. So, instead of +8 +4 ... etc, user will now be able to choose font size, ie: 4,5,6,7,8,9,10...24. I tested the change and it works properly. I attached the diff file

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-20 Thread Sake Sashimi
Hi Kakaroto, Thanks for your reply. I was previously thinking that the size column was not there because amsn already has the menu entry to increase or decrease the text size. Therefore, with this in mind, the person who implemented the Change Font window purposedly left out the size column F

Re: [Amsn-devel] Better usable menu options for the change text size

2007-03-20 Thread Youness Alaoui
Hi Sake, Like vivia said, the best way to send a patch is to save your work, do a 'svn update', then 'svn diff', and send us the diff result... Now, I'm sorry but I don't understand what you did... with this fix... it has nothing to do with what was asked... Maybe you forgot to send the diff f