lol, ok
On Fri, Jan 04, 2008 at 10:10:19AM +, square87 wrote:
> 2008/1/4, Youness Alaoui <[EMAIL PROTECTED]>:
> >
> > btw, square, since you're part of the team now, can you review and take
> > care of this guy's patches ? :p
> > seriously though, you're used to how I work now, so if you could
2008/1/4, Youness Alaoui <[EMAIL PROTECTED]>:
>
> btw, square, since you're part of the team now, can you review and take
> care of this guy's patches ? :p
> seriously though, you're used to how I work now, so if you could reread
> all your diff to see if you think of something that isn't right bef
btw, square, since you're part of the team now, can you review and take care of
this guy's patches ? :p
seriously though, you're used to how I work now, so if you could reread all
your diff to see if you think of something that isn't right before
committing.
thanks :)
KKRT
On Mon, Dec 17, 2007
2007/12/17, Youness Alaoui <[EMAIL PROTECTED]>:
>
> oh man! not again! lol, ok, I'll check your diffs, but not now, when I
> wake up...
> Just let me comment below...
>
> ok, I understand you, but you are doing it completely wrong!!! what we do
> there is to SAVE the identifier of the new DP, if we
oh man! not again! lol, ok, I'll check your diffs, but not now, when I wake
up...
Just let me comment below...
On Mon, Dec 17, 2007 at 03:36:00PM +, square87 wrote:
> Hi KaKaRoTo :)
>
> Thanks for "all of this is some very well done work" :) also my patch to add
> styles and colors in topcw
Hi KaKaRoTo :)
Thanks for "all of this is some very well done work" :) also my patch to add
styles and colors in topcw was good :P lol
Ok, now that i know what it was committed (almost all :P) i send a new diffs
to correct other things.
6-1.diff
So here i answer what do you asked me
"why AND if
Alright now for the comments!
On Sun, Dec 16, 2007 at 06:59:38PM +, square87 wrote:
> Here i am
> So i split my diff file in 7 diffs... don't tell me now that they are too
> many! :D
>
> In some diffs i haven't put code indentation, so it should be more simple to
> read the "svn diff" result.
On Sun, Dec 16, 2007 at 06:59:38PM +, square87 wrote:
> Here i am
> So i split my diff file in 7 diffs... don't tell me now that they are too
> many! :D
>
no, that's cool! Thanks a lot! :)
> In some diffs i haven't put code indentation, so it should be more simple to
> read the "svn diff" r
Here i am
So i split my diff file in 7 diffs... don't tell me now that they are too
many! :D
In some diffs i haven't put code indentation, so it should be more simple to
read the "svn diff" result. If you commit a change please check the code
indentation, i love it :P
1.diff
We compare: $user_nam
lol, no, not one diff per line :p
but you did change a lot of stuff, every change that should be considered as a
whole should be in a different file. one file for the dp
thing, one file for the nick comparison, etc... I also noticed you removed the
checks for the run_alarm, I didn't see it menti
uff... :P
but i changed only a proc and i write what I changed and why.
It's all about one ( 1 ) proc, should i send a diff file for every line? :P
I changed various things...ok but i explained what i changed and why, so you
can decide.
For me, the codes to (download and) load a DP (if newDP != ol
argh.. I thought the whole patch was for one thing... I already told him to
make small diffs and separate diff files for different
changes...
square! You're not listening! I'm coming to kick you! :p
KKRT
On Sun, Dec 16, 2007 at 10:00:44AM +, Tom Hennigan wrote:
> Square87 thanks for looking
Square87 thanks for looking at the code. This is a fairly large patch
so near to a release.. I have work today, so I can't do this for you,
but it may be better to split each patch into a separate diff.. Then
it will be easy to review your changes.. I will take time to look at
this, but as
can someone review this.. cause I can't.. it's just too much stuff in there...
On Sat, Dec 15, 2007 at 03:29:52PM +, square87 wrote:
> Hello
> I found some "strange" behaviors in the proc "cmsn_change_state" of
> protocol.tcl.
> I write a patch. I (try to) explain what i changed and why.
>
>
Hello
I found some "strange" behaviors in the proc "cmsn_change_state" of
protocol.tcl.
I write a patch. I (try to) explain what i changed and why.
The diff file is the result of "svn diff";
The txt file is "the diff file without old differences".
--
In the original version there is:
15 matches
Mail list logo
