It is repetitive, but it's better to have it repetitive instead of having
someone call the function with ""
I was going to put a PutLog $chatid "" $msg "" 1
but then I changed "" to [trans deliverfail] just like that,..
PutLog is the one in charge of writing the deliverfail message in case $failed
Hello
Since it's a warning i think that deliverfail should be in red, for this i
have write:
set user "\|\"LRED[trans deliverfail]"
instead of
set user [trans deliverfail]
If you put: set user [trans deliverfail] we'll see in log conversation
deliverfail with the same color of our text and near th
true, good point! :) but in practice, the failed is set to 1 when fontformat is
set to "", so it's ok ;) but
I'll change it anyways, just to make it a clean code.
thanks for the correction! :)
KKRT
On Fri, Feb 02, 2007 at 07:26:25AM +0100, square87 wrote:
> Hello.
> KKRT
> You have added
>
> p
Hello.
KKRT
You have added
proc PutLog { chatid user msg {fontformat ""} {failed 0}} {
if {$fontformat == ""} {
set color "NOR"
} elseif { $failed == 1 } {
set color "RED"
# When the message failed to deliver, we should show the
deliver
Ok, I committed it, you can read the diff in the amsn-commits mailing list.
I also fixed some weird unclean code, we were using $user to check if
{[::OIM_GUI::isOIM $user] } where $user is
supposed to be the nickname of a user, not his email, so I changed it to
$chatid.
But it worked before bec
ok, your code is wrong, but it's ok, we know you're not a programmer.
but what if the error happens in a multi user conversation ?
what if it happens after you closed the window ? You also added the fontformat
argument but it's not used
anywhere in the code...
I'll fix it, commit and read the c
Humm... I also agree, and I don't immediatly see a reason why not to add it. +
if it's wrong, we can always
revert the change.. I'll commit it.
Thanks square! :D
KKRT
On Fri, Feb 02, 2007 at 02:34:28PM +1300, majinsoftware wrote:
> good idea add it.
> --
good idea add it.
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 bas
Good idea!
What do others think? add patch to SVN ?
KKRT
On Thu, Feb 01, 2007 at 06:47:52PM +0100, square87 wrote:
> Hello.
> Sometime sending message fails so the user don't read what we have written,
> but the log system logs not-sending-messages, too.
> When we read the conversation, for exam
Hello.
Sometime sending message fails so the user don't read what we have written,
but the log system logs not-sending-messages, too.
When we read the conversation, for example, after two weeks we don't
remember if certain messages are sending or not.
So i think that this patch is useful.
I am not
10 matches
Mail list logo
