Re: [android-building] Soong build system conditional question

2018-01-17 Thread Manoj Basapathi
Hi , I also followed similar steps , build flag is not updating with proper value. Is there any thing we need to take care apart from these changes. Please let us know. Thanks, Manoj On Wednesday, 24 May 2017 19:59:12 UTC+5:30, Jeffrey An wrote: > > Hi, > With your comment, finally it works.

Re: [android-building] Soong build system conditional question

2017-05-24 Thread Jeffrey An
Hi, With your comment, finally it works. But I have another issue. I added BOARD_HAVE_EXT_AVDT := true and avdt_ext.cc file was compiled. But I removed BOARD_HAVE_EXT_AVDT := true in BoardConfig.mk(device/huawei/angler/) but still avdt_ext.cc file was compiled. Without BOARD_HAVE_EXT_AVDT :=

Re: [android-building] Soong build system conditional question

2017-05-23 Thread Colin Cross
The property in the Android.bp file should be "ext_avd", not "Ext_avd". The required capitalization in the go files is an unfortunate consequence of reflection requiring exported go fields. On Tue, May 23, 2017 at 12:29 AM, Jeffrey An wrote: > Hi, > > Thanks for the

Re: [android-building] Soong build system conditional question

2017-05-23 Thread Jeffrey An
Hi, Thanks for the answer! I understand the purpose of the soong build system. As you said, for local experimentation, I've tried like below, build/soong diff --git a/android/variable.go b/android/variable.go old mode 100644 new mode 100755 index 163113e..475cee0 --- a/android/variable.go +++

Re: [android-building] Soong build system conditional question

2017-05-22 Thread Colin Cross
One of our goals for build health is to reduce the number of different ways we build modules. Adding too many build flags makes it harder to tell if a change will break the build, and hard to run tests. We would much rather compiling everything the same on all devices, and then determine which