Re: [android-developers] UnknownHostException is not logged

2013-02-05 Thread b0b
On Tuesday, 5 February 2013 11:46:42 UTC+1, BoD wrote: > > FYI there was already an open bug for this: > http://code.google.com/p/android/issues/detail?id=21436 > > I really think this change should be reverted, instead of 'fixing' the > javadoc. Seriously, the logger should not decide for the d

Re: [android-developers] UnknownHostException is not logged

2013-02-05 Thread BoD
FYI there was already an open bug for this: http://code.google.com/p/android/issues/detail?id=21436 I really think this change should be reverted, instead of 'fixing' the javadoc. Seriously, the logger should not decide for the developer what is an important exception or not - this doesn't make

Re: [android-developers] UnknownHostException is not logged

2013-01-28 Thread Robert Greenwalt
I think a case could also be made for logging the UnknownHostException without the stack trace (just the server name) as an in between step. Thanks for the bugreport. On Fri, Jan 25, 2013 at 3:08 PM, Boris Burtin wrote: > Thanks for responding. I can see the reasoning. Just seems weird that

Re: [android-developers] UnknownHostException is not logged

2013-01-25 Thread Boris Burtin
Thanks for responding. I can see the reasoning. Just seems weird that the behavior isn't documented, and that there's no way for me to override it. I'll file a bug for updating the Javadoc. On Friday, January 25, 2013 2:40:10 PM UTC-8, Robert Greenwalt wrote: > > You can always do the dns loo

Re: [android-developers] UnknownHostException is not logged

2013-01-25 Thread Robert Greenwalt
You can always do the dns lookup yourself and log an error if it's invalid. The DNS cache will ensure it's not wasted effort. On Fri, Jan 25, 2013 at 2:39 PM, Robert Greenwalt wrote: > I think the log was getting quite full of these exceptions (mobile devices > often don't have a network and ap

Re: [android-developers] UnknownHostException is not logged

2013-01-25 Thread Robert Greenwalt
I think the log was getting quite full of these exceptions (mobile devices often don't have a network and apps aren't so good at checking that first) so we stopped logging them. If you look at the blame for this code you can see the reasoning. On Fri, Jan 25, 2013 at 2:31 PM, Boris Burtin wrot

[android-developers] UnknownHostException is not logged

2013-01-25 Thread Boris Burtin
I was racking my brain, trying to figure out why one of my users was having trouble connecting and nothing was in the logs. Finally I looked at the Android source and realized that the logging code explicitly ignores UnknownHostException. Even worse, the Javadoc doesn't specify this behavior.