cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-12-31 Thread rbb
rbb 99/12/30 17:16:53 Modified:src/lib/apr/file_io/unix open.c Log: Fix a nasty little bug that was causing a seg fault everytime we tried starting Apache with an existing pid file. When APR allocates space, it has to allocate the right amount. Revision ChangesPath

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-11-15 Thread rbb
rbb 99/11/15 07:05:14 Modified:src/lib/apr/file_io/unix open.c Log: This is a needed addition to "putting" files into APR on Unix. Revision ChangesPath 1.23 +2 -0 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c ===

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-11-04 Thread manoj
manoj 99/11/04 14:04:19 Modified:src/lib/apr/file_io/unix open.c Log: Change ap_open's behavior when using APR_OS_DEFAULT permissions. My Linux man pages say that you must provide permissions to use when creating a file. We weren't doing so, and non APR_BUFFERED files were cr

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-11-04 Thread manoj
manoj 99/11/04 13:59:23 Modified:src/lib/apr/file_io/unix open.c Log: Save a little bit of work when opening a file with default permissions. Revision ChangesPath 1.20 +1 -2 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c ==

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-11-01 Thread manoj
manoj 99/10/31 20:24:09 Modified:src/lib/apr/file_io/unix open.c Log: A little more cleanup. Buffered mode complicates things. Revision ChangesPath 1.19 +1 -2 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c =

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-11-01 Thread manoj
manoj 99/10/31 19:58:15 Modified:src/lib/apr/file_io/unix open.c Log: Fix a thinko I made in the last commit. Revision ChangesPath 1.18 +1 -1 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c ==

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-11-01 Thread manoj
manoj 99/10/31 19:20:53 Modified:src/lib/apr/file_io/unix open.c Log: Some cleanup Revision ChangesPath 1.17 +10 -6 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c === RCS file: /

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-09-13 Thread rbb
rbb 99/09/13 07:06:42 Modified:src/lib/apr/file_io/unix open.c Log: Fix the bug dealing with opening files on Unix Revision ChangesPath 1.11 +2 -1 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c ===

Re: cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-09-13 Thread Ryan Bloom
> Yeah but filedes == 0 when you use filehand (which is possibly a bug). OK. This is the bug. Filedes should be -1. I don't know how I missed that in my testing, because we are using filedes all over the place. I'll fix this ASAP. > OK, well it didn't work before, and it now does _when_ it is

Re: cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-09-13 Thread Ben Laurie
Ryan Bloom wrote: > > > > > -if ((*new)->filedes < 0 && (*new)->filehand == NULL) { > > +if ((*new)->filedes < 0 || (*new)->filehand == NULL) { > > (*new)->filedes = -1; > > (*new)->eof_hit = 1; > >return errno; > > This is wrong. This says that we NEV

Re: cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-09-13 Thread Ryan Bloom
> > -if ((*new)->filedes < 0 && (*new)->filehand == NULL) { > +if ((*new)->filedes < 0 || (*new)->filehand == NULL) { > (*new)->filedes = -1; > (*new)->eof_hit = 1; >return errno; This is wrong. This says that we NEVER open the file correctly. This

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-09-12 Thread ben
ben 99/09/12 05:10:12 Modified:src/lib/apr/file_io/unix open.c Log: Initialise data structure correctly in ap_put_os_file. Revision ChangesPath 1.10 +1 -1 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c ===

cvs commit: apache-2.0/src/lib/apr/file_io/unix open.c

1999-09-11 Thread ben
ben 99/09/11 13:42:58 Modified:src/lib/apr/file_io/unix open.c Log: Test for open failure correctly. Revision ChangesPath 1.8 +1 -1 apache-2.0/src/lib/apr/file_io/unix/open.c Index: open.c =