[apparmor] GSoC review r30

2013-08-01 Thread Christian Boltz
Hello, the review for r30 is attached - it had lots of new code (and interesting[tm] regexes) - therefore I have several notes about it ;-) @John: The review contains some questions for you - can you please answer them? Regards, Christian Boltz -- > > My calendar shows May 12th to be a Friday

Re: [apparmor] [PATCH 1/2] tests: Add an optional final check to checktestfg and checktestbg

2013-08-01 Thread John Johansen
On 08/01/2013 02:01 AM, Tyler Hicks wrote: > Allows for the test script to specify a final check to be performed > after checking the output of the test binary. This may be useful, for > example, if the test script wants to compare logging output of the test > binary to known-good logging output. >

Re: [apparmor] apparmor and affinity mask

2013-08-01 Thread John Johansen
On 08/01/2013 01:38 AM, Jeroen Ooms wrote: > I would like to restrict the number of cores/cpu's that a certain > process can use. The affinity mask provides one method by restricting > which of the processors are available to the process. However, > unfortunately there is not rlimit_affinity in lin

[apparmor] [PATCH 1/2] tests: Add an optional final check to checktestfg and checktestbg

2013-08-01 Thread Tyler Hicks
Allows for the test script to specify a final check to be performed after checking the output of the test binary. This may be useful, for example, if the test script wants to compare logging output of the test binary to known-good logging output. Signed-off-by: Tyler Hicks --- I'm not real happy

[apparmor] [PATCH 2/2] tests: Add regression tests for dbus

2013-08-01 Thread Tyler Hicks
Integrate dbus tests into the regression testing framework. This started out as dbus-send.c, from the dbus source, and then grew from there. dbus_message is an example "client" program that only sends out messages. dbus_service binds to a well-known name and then listens and responds to incoming

[apparmor] apparmor and affinity mask

2013-08-01 Thread Jeroen Ooms
I would like to restrict the number of cores/cpu's that a certain process can use. The affinity mask provides one method by restricting which of the processors are available to the process. However, unfortunately there is not rlimit_affinity in linux, so any process can reset its own affinity mask.

[apparmor] [PATCH 1/2] libaalogparse: Parse dbus-daemon audit messages

2013-08-01 Thread Tyler Hicks
This requires libaalogparse to become aware of USER_AVC messages. Signed-off-by: Tyler Hicks --- libraries/libapparmor/src/aalogparse.h| 7 +++ libraries/libapparmor/src/grammar.y | 72 ++- libraries/libapparmor/src/libaalogparse.c | 12 ++ libraries/li

[apparmor] [PATCH 2/2] libaalogparse: Regression tests for dbus-daemon audit messages

2013-08-01 Thread Tyler Hicks
Test a set of send, bind, and receive denials routed through the syslog, as well as a set routed through auditd. Signed-off-by: Tyler Hicks --- libraries/libapparmor/testsuite/test_multi.c | 16 .../testsuite/test_multi/testcase_dbus_01.err | 0 .../testsuite