Re: [apparmor] GSoC review r30

2013-08-02 Thread John Johansen
On 08/01/2013 02:59 PM, Christian Boltz wrote: > Hello, > > the review for r30 is attached - it had lots of new code (and > interesting[tm] regexes) - therefore I have several notes about it ;-) > > @John: The review contains some questions for you - can you please answer > them? > > === modi

[apparmor] RFC: Patch [Bug 1207424] Re: mod_apparmor should let me use ServerName as default hat name

2013-08-02 Thread John Johansen
This is a first pass at providing the feature requested in Bug 1207424 It leverages the appache config option AADefaultHatName and when its value is specified as the hostname will be looked up and used. Obviously this patch isn't complete, but its a first pass and I wanted feedback before

[apparmor] [PATCH] required feature test for regression tests

2013-08-02 Thread John Johansen
This quick little patch adds the ability to specify the features required for a test to run. This will help keep the regression suite from reporting a lot of failures when it hits a kernel that doesn't support the feature being tested. its current iteration is pretty brain dead, only testing for t

Re: [apparmor] [PATCH 2/2] tests: Add regression tests for dbus

2013-08-02 Thread John Johansen
On 08/01/2013 02:01 AM, Tyler Hicks wrote: > Integrate dbus tests into the regression testing framework. > > This started out as dbus-send.c, from the dbus source, and then grew > from there. > > dbus_message is an example "client" program that only sends out > messages. dbus_service binds to a w

[apparmor] [PATCH] libapparmor: ENOENT should only signify label not found in label queries

2013-08-02 Thread Tyler Hicks
When doing label queries with aa_query_label(), there are a number of error conditions that can occur. Most of them indicate that the query could not happen. That may be because the application provided invalid input, memory allocation failed, the kernel doesn't support queries, libapparmor and the

Re: [apparmor] [PATCH] libapparmor: ENOENT should only signify label not found in label queries

2013-08-02 Thread Tyler Hicks
On 2013-08-02 12:40:50, Tyler Hicks wrote: > When doing label queries with aa_query_label(), there are a number of > error conditions that can occur. Most of them indicate that the query > could not happen. That may be because the application provided invalid > input, memory allocation failed, the

Re: [apparmor] [PATCH] required feature test for regression tests

2013-08-02 Thread Tyler Hicks
On 2013-08-02 03:07:56, John Johansen wrote: > This quick little patch adds the ability to specify the features required > for a test to run. This will help keep the regression suite from reporting > a lot of failures when it hits a kernel that doesn't support the feature > being tested. > > its c

[apparmor] [PATCH 2/2 v2] tests: Add regression tests for dbus

2013-08-02 Thread Tyler Hicks
Integrate dbus tests into the regression testing framework. This started out as dbus-send.c, from the dbus source, and then grew from there. dbus_message is an example "client" program that only sends out messages. dbus_service binds to a well-known name and then listens and responds to incoming

Re: [apparmor] GSoC review r30

2013-08-02 Thread Christian Boltz
Hello, John Johansen wrote: > On 08/01/2013 02:59 PM, Christian Boltz wrote: > ### a check if the hat already exists might be useful to avoid duplicate > hat names (which might get merged on write, but I doubt that's intended > behaviour) > > ### interestingly, the parser does _not_ complain abou