Re: [apparmor] [PATCH 3/8] add optional allow prefix to the language v2

2013-09-16 Thread Steve Beattie
On Mon, Sep 16, 2013 at 05:06:51PM -0700, Seth Arnold wrote: > On Mon, Sep 16, 2013 at 04:49:49PM -0700, Steve Beattie wrote: > > Index: b/parser/tst/simple_tests/capability/ok_dup_allow5.sd > > === > > --- /dev/null > > +++ b/parser/t

Re: [apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Kshitij Gupta
Hello, If you're fixing the profile, you might want to consider streamlining it. The following rules are superfluous from the following includes: @{PROC}/sys/kernel/ngroups_max, /etc/gai.conf abstractions/base, abstractions/nameservice Regards, Kshitij Gupta On 9/17/13, Christian Boltz wrote:

Re: [apparmor] [PATCH 3/8] add optional allow prefix to the language v2

2013-09-16 Thread Seth Arnold
On Mon, Sep 16, 2013 at 04:49:49PM -0700, Steve Beattie wrote: > Index: b/parser/tst/simple_tests/capability/ok_dup_allow5.sd > === > --- /dev/null > +++ b/parser/tst/simple_tests/capability/ok_dup_allow5.sd > @@ -0,0 +1,17 @@ > +# > +

Re: [apparmor] [PATCH 3/8] add optional allow prefix to the language v2

2013-09-16 Thread Steve Beattie
Based on my review of the first version of this patch, I've updated it, as follows. From: John Johansen let allow be used as a prefix in place of deny. Allow is the default and is implicit so it is not needed but some user keep tripping over it, and it makes the language more symmetric eg.

Re: [apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Christian Boltz
Hello, Am Montag, 16. September 2013 schrieb Steve Beattie: > On Mon, Sep 16, 2013 at 10:39:13PM +0200, Christian Boltz wrote: > > I just received the following patch and propose it for 2.8 and > > trunk: > > > > Patch-Author: Stefan Seyfried > > > > After this change in ntp: > > > > * Mo Aug

Re: [apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Seth Arnold
On Mon, Sep 16, 2013 at 10:39:13PM +0200, Christian Boltz wrote: > Hello, > > I just received the following patch and propose it for 2.8 and trunk: > > > > Patch-Author: Stefan Seyfried > > After this change in ntp: > > * Mo Aug 19 2013 crrodrig...@opensuse.org > - Build with -DOPENSSL_LOAD_

Re: [apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Steve Beattie
On Mon, Sep 16, 2013 at 10:39:13PM +0200, Christian Boltz wrote: > I just received the following patch and propose it for 2.8 and trunk: > > Patch-Author: Stefan Seyfried > > After this change in ntp: > > * Mo Aug 19 2013 crrodrig...@opensuse.org > - Build with -DOPENSSL_LOAD_CONF , ntp must re

[apparmor] [patch] ntpd needs read access to openssl.cnf

2013-09-16 Thread Christian Boltz
Hello, I just received the following patch and propose it for 2.8 and trunk: Patch-Author: Stefan Seyfried After this change in ntp: * Mo Aug 19 2013 crrodrig...@opensuse.org - Build with -DOPENSSL_LOAD_CONF , ntp must respect and use the system's openssl configuration. we need to read op

[apparmor] [patch] libapparmor python binding - fix 32bit test failures

2013-09-16 Thread Steve Beattie
The python bindings were using the wrong data type cast (long long instead of just long) on the value '-1' that is used to indicate no value for the 'fsuid' and 'ouid' fields in the returned data structure. Thus a bunch of the tests were failing in 32bit environments. This patch corrects the issue

Re: [apparmor] [patch] libapparmor python binding - fix 32bit test failures

2013-09-16 Thread Seth Arnold
On Mon, Sep 16, 2013 at 09:42:23AM -0700, Steve Beattie wrote: > The python bindings were using the wrong data type cast (long long > instead of just long) on the value '-1' that is used to indicate no > value for the 'fsuid' and 'ouid' fields in the returned data structure. > Thus a bunch of the t