Re: [apparmor] [PATCH 5/5] tests: Add regression tests for dbus eavesdrop rules

2013-12-06 Thread Tyler Hicks
On 2013-12-05 18:59:11, Seth Arnold wrote: On Tue, Nov 19, 2013 at 06:16:25PM -0800, Tyler Hicks wrote: Simple regression test that calls AddMatch using a match string that sets up eavesdropping on all method call messages. The shell script file runs the test unconfined and under a

Re: [apparmor] [patch 04/12] parser: add more convert_aaregex_to_pcre() unit tests

2013-12-06 Thread Seth Arnold
On Fri, Dec 06, 2013 at 06:10:55AM -0800, Steve Beattie wrote: I think one more case would be useful, to check that /**/ works as expected: MY_REGEX_TEST(/**/, /[^/\\x00][^\\x00]*/, ePatternTailGlob); Does that look right? Correct except for the type returned, which will be

[apparmor] [patch] fix broken english in parser_yacc.y

2013-12-06 Thread Christian Boltz
Hello, I think the patch (and $SUBJECT) speaks for itsself ;-) === modified file 'parser/parser_yacc.y' --- parser/parser_yacc.y2013-09-28 00:26:39 + +++ parser/parser_yacc.y2013-12-06 18:52:41 + @@ -657,7 +657,7 @@ rules: rules opt_prefix mnt_rule {

Re: [apparmor] [patch] fix broken english in parser_yacc.y

2013-12-06 Thread Steve Beattie
On Fri, Dec 06, 2013 at 07:54:29PM +0100, Christian Boltz wrote: Hello, I think the patch (and $SUBJECT) speaks for itsself ;-) Acked-by: Steve Beattie st...@nxnw.org Thanks. -- Steve Beattie sbeat...@ubuntu.com http://NxNW.org/~steve/ signature.asc Description: Digital signature --

Re: [apparmor] [patch] fix broken english in parser_yacc.y

2013-12-06 Thread John Johansen
On 12/06/2013 11:22 AM, Seth Arnold wrote: On Fri, Dec 06, 2013 at 07:54:29PM +0100, Christian Boltz wrote: Hello, I think the patch (and $SUBJECT) speaks for itsself ;-) What's the deal with the po/apparmor-parser.pot file? Do we need to update this file when we change the msgid strings

[apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-06 Thread Tyler Hicks
By default, statically link against the in-tree libapparmor. If the in-tree libapparmor is not yet built, print a helpful error message. To build against the system libapparmor, the SYSTEM_LIBAPPARMOR make variable can be set on the command line like so: $ make SYSTEM_LIBAPPARMOR=1 This patch