Re: [apparmor] [patch] bump libapparmor1 to libapparmor2

2014-02-24 Thread Steve Beattie
On Mon, Feb 24, 2014 at 11:13:23PM -0800, Steve Beattie wrote: > On Mon, Feb 24, 2014 at 04:23:13PM -0800, Seth Arnold wrote: > > In the course of building updated apparmor 2.8.95 packages for Ubuntu, I > > updated the libtool variables to: > > > > AA_LIB_CURRENT = 2 > > AA_LIB_REVISION = 0 > > AA

Re: [apparmor] [patch] bump libapparmor1 to libapparmor2

2014-02-24 Thread Steve Beattie
On Mon, Feb 24, 2014 at 04:23:13PM -0800, Seth Arnold wrote: > In the course of building updated apparmor 2.8.95 packages for Ubuntu, I > updated the libtool variables to: > > AA_LIB_CURRENT = 2 > AA_LIB_REVISION = 0 > AA_LIB_AGE = 0 > > To match the new '2' version we need to update the > librar

[apparmor] [patch] bump libapparmor1 to libapparmor2

2014-02-24 Thread Seth Arnold
In the course of building updated apparmor 2.8.95 packages for Ubuntu, I updated the libtool variables to: AA_LIB_CURRENT = 2 AA_LIB_REVISION = 0 AA_LIB_AGE = 0 To match the new '2' version we need to update the libraries/libapparmor/configure.ac to know that this is libapparmor2. I propose this

Re: [apparmor] [patch] complain flag is enough, no symlink needed

2014-02-24 Thread Steve Beattie
On Tue, Feb 25, 2014 at 12:20:33AM +0100, Christian Boltz wrote: > Hello, > > let me compile 20 minutes of discussions into the addition of a # ;-) > > > Change aa-complain / set_complain() to (only) add the complain flag. > We don't need to additionally create a force-complain symlink. Ac

[apparmor] [Bug 1180230] Re: glob in aa-genprof repeats same option

2014-02-24 Thread Christian Boltz
This patch was commited to 2.8 branch and trunk, and later changed to use grep instead of ~~~. AppArmor 2.8.3 contains the fix. ** Changed in: apparmor Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of AppArmor Developers, which is a

[apparmor] [patch] complain flag is enough, no symlink needed

2014-02-24 Thread Christian Boltz
Hello, let me compile 20 minutes of discussions into the addition of a # ;-) Change aa-complain / set_complain() to (only) add the complain flag. We don't need to additionally create a force-complain symlink. === modified file 'utils/apparmor/aa.py' --- utils/apparmor/aa.py2014-02-

Re: [apparmor] [patch] utils: fix cmd reference in apparmor/tools.py

2014-02-24 Thread Christian Boltz
Hello, Am Montag, 24. Februar 2014 schrieb Steve Beattie: > This patch fixes up the parser command invocation via > apparmor/common.py:cmd(), as it handles stdout/stderr redirection, > and the redirection that was being attempted were being handed as > arguments to the parser. Nice, good catch!

Re: [apparmor] [patch] libapparmor README

2014-02-24 Thread Steve Beattie
On Mon, Feb 24, 2014 at 10:04:59PM +0100, Christian Boltz wrote: > this patch updates the bugtracker link in the libapparmor README. Acked-by: Steve Beattie -- Steve Beattie http://NxNW.org/~steve/ signature.asc Description: Digital signature -- AppArmor mailing list AppArmor@lists.ubuntu.

[apparmor] [patch] libapparmor README

2014-02-24 Thread Christian Boltz
Hello, this patch updates the bugtracker link in the libapparmor README. === modified file 'libraries/libapparmor/README' --- libraries/libapparmor/README2008-05-19 22:48:31 + +++ libraries/libapparmor/README2014-02-24 20:45:19 + @@ -1,1 +1,3 @@ -What little documentation

[apparmor] [patch] utils: split out disable functionality in apparmor/tools.py

2014-02-24 Thread Steve Beattie
This patch splits out the disable functionality from the apparmor/tools.py:act() method into a separate cmd_disable() method. The intent is to unwind the logic in act() into smaller, more digestible chunks, while sharing commonality via helper functions (e.g. the added get_next_to_profile() functio

Re: [apparmor] [patch] new profile tools - handling of "(F)inish"

2014-02-24 Thread Kshitij Gupta
On Feb 25, 2014 12:15 AM, "Christian Boltz" wrote: > > Hello, > > [patch v2, see below] > > Am Montag, 27. Januar 2014 schrieb Christian Boltz: > > currently, selecting (F)inish in the new profile tools basically means > > aborting without saving anything. However, we already have Abo(r)t > > for

Re: [apparmor] [patch] common.py: add debugging, py2 compat fix

2014-02-24 Thread Kshitij Gupta
On Feb 25, 2014 12:47 AM, "Steve Beattie" wrote: > > On Mon, Feb 24, 2014 at 07:58:57PM +0100, Christian Boltz wrote: > > Hello, > > > > this patch fixes two (unrelated) issues in common.py: > > - it adds some debug logging in valid_path() > > - it fixes a py2 incompability in DebugLogger.__init__

Re: [apparmor] [patch] common.py: add debugging, py2 compat fix

2014-02-24 Thread Steve Beattie
On Mon, Feb 24, 2014 at 07:58:57PM +0100, Christian Boltz wrote: > Hello, > > this patch fixes two (unrelated) issues in common.py: > - it adds some debug logging in valid_path() > - it fixes a py2 incompability in DebugLogger.__init__ > > > === modified file 'utils/apparmor/common.py' > --- uti

[apparmor] [patch] common.py: add debugging, py2 compat fix

2014-02-24 Thread Christian Boltz
Hello, this patch fixes two (unrelated) issues in common.py: - it adds some debug logging in valid_path() - it fixes a py2 incompability in DebugLogger.__init__ === modified file 'utils/apparmor/common.py' --- utils/apparmor/common.py2014-02-12 23:54:00 + +++ utils/apparmor/common.py

[apparmor] [patch] utils: fix cmd reference in apparmor/tools.py

2014-02-24 Thread Steve Beattie
This patch fixes up the parser command invocation via apparmor/common.py:cmd(), as it handles stdout/stderr redirection, and the redirection that was being attempted were being handed as arguments to the parser. (As an aside, we generally try to avoid invoking the shell when running external comma

Re: [apparmor] [patch] new profile tools - handling of "(F)inish"

2014-02-24 Thread Christian Boltz
Hello, [patch v2, see below] Am Montag, 27. Januar 2014 schrieb Christian Boltz: > currently, selecting (F)inish in the new profile tools basically means > aborting without saving anything. However, we already have Abo(r)t > for that ;-) > > (F)inish should ask the user if he wants to save the c