Re: [apparmor] [patch] utils: split out disable functionality in apparmor/tools.py

2014-02-27 Thread Seth Arnold
On Mon, Feb 24, 2014 at 12:16:49PM -0800, Steve Beattie wrote: > This patch splits out the disable functionality from the > apparmor/tools.py:act() method into a separate cmd_disable() > method. The intent is to unwind the logic in act() into smaller, more > digestible chunks, while sharing commona

Re: [apparmor] [patch] fix test-aa-decode.py

2014-02-27 Thread Seth Arnold
On Thu, Feb 27, 2014 at 03:58:00PM -0800, Steve Beattie wrote: > On Thu, Feb 27, 2014 at 09:47:35PM +0100, Christian Boltz wrote: > > test-aa-decode.py is also called by "make check" (utils/Makefile), but > > as "test/test-aa-decode.py" - and if called this way, ./aa-decode is > > right because i

Re: [apparmor] [patch] fix test-aa-decode.py

2014-02-27 Thread Steve Beattie
On Thu, Feb 27, 2014 at 09:47:35PM +0100, Christian Boltz wrote: > test-aa-decode.py is also called by "make check" (utils/Makefile), but > as "test/test-aa-decode.py" - and if called this way, ./aa-decode is > right because it has a different pwd. > > Looks like we should find a solution that w

Re: [apparmor] [patch] [2.9] Fix uninitialized capability entries

2014-02-27 Thread Steve Beattie
On Thu, Feb 27, 2014 at 01:26:01PM -0800, John Johansen wrote: > The capability entries in the profile are not being correctly initialized to 0 > > Signed-off-by: John Johansen Acked-by: Steve Beattie Thanks. -- Steve Beattie http://NxNW.org/~steve/ signature.asc Description: Digital sign

Re: [apparmor] [patch] common.py: add recursive_print()

2014-02-27 Thread Christian Boltz
Hello, Am Donnerstag, 27. Februar 2014 schrieb Jamie Strandboge: > On 02/27/2014 02:04 PM, Christian Boltz wrote: > > Am Donnerstag, 27. Februar 2014 schrieb Jamie Strandboge: > >> On 02/26/2014 06:48 PM, Christian Boltz wrote: > >>> this patch adds recursive_print() to common.py. > >> Is pprint

[apparmor] [patch] [2.9] Fix uninitialized capability entries

2014-02-27 Thread John Johansen
The capability entries in the profile are not being correctly initialized to 0 Signed-off-by: John Johansen === modified file 'parser/profile.h' --- parser/profile.h2013-12-10 20:42:50 + +++ parser/profile.h2014-02-27 21:23:17 + @@ -82,7 +82,7 @@ uint64_t deny; ui

Re: [apparmor] [patch] fix test-aa-decode.py

2014-02-27 Thread Christian Boltz
Hello, Am Donnerstag, 27. Februar 2014 schrieb Christian Boltz: > this patch fixes test-aa-decode.py - it failed all tests because the > path to aa-decode was wrong. > > > === modified file 'utils/test/test-aa-decode.py' > --- utils/test/test-aa-decode.py2012-11-06 01:27:20 + > +++ u

Re: [apparmor] [patch] common.py: add recursive_print()

2014-02-27 Thread Jamie Strandboge
On 02/27/2014 02:04 PM, Christian Boltz wrote: > Hello, > > Am Donnerstag, 27. Februar 2014 schrieb Jamie Strandboge: >> On 02/26/2014 06:48 PM, Christian Boltz wrote: >>> this patch adds recursive_print() to common.py. >>> >>> It prints a data structure in an easily readable output and is quite >

Re: [apparmor] [PATCH] add /var/www/html to abstractions/web-data

2014-02-27 Thread Christian Boltz
Hello, Am Donnerstag, 27. Februar 2014 schrieb Jamie Strandboge: > This patch adds /var/www/html to abstractions/web-data, which is the > path used for document root on Debian and its derivatives[1]. > Nominated for 2.8. Acked-by: Christian Boltz for trunk and 2.8 That said - would it make sens

Re: [apparmor] [patch] Post merge test fixes

2014-02-27 Thread Christian Boltz
Hello, Am Donnerstag, 27. Februar 2014 schrieb Kshitij Gupta: > I ran the tests locally using apparmor/utils/test/runtests-py2.sh and > ended up with a lot of broken tests. I've fixed the tests for the > tools, which required adapting to new directory structure and fixing a > couple of values. The

[apparmor] [patch] fix test-aa-decode.py

2014-02-27 Thread Christian Boltz
Hello, this patch fixes test-aa-decode.py - it failed all tests because the path to aa-decode was wrong. === modified file 'utils/test/test-aa-decode.py' --- utils/test/test-aa-decode.py2012-11-06 01:27:20 + +++ utils/test/test-aa-decode.py2014-02-27 20:10:20 + @@ -18,7

Re: [apparmor] [patch] common.py: add recursive_print()

2014-02-27 Thread Christian Boltz
Hello, Am Donnerstag, 27. Februar 2014 schrieb Jamie Strandboge: > On 02/26/2014 06:48 PM, Christian Boltz wrote: > > this patch adds recursive_print() to common.py. > > > > It prints a data structure in an easily readable output and is quite > > useful[1] for debugging. However, I don't recommen

Re: [apparmor] [patch] common.py: add recursive_print()

2014-02-27 Thread Jamie Strandboge
On 02/26/2014 06:48 PM, Christian Boltz wrote: > Hello, > > this patch adds recursive_print() to common.py. > > It prints a data structure in an easily readable output and is quite > useful[1] for debugging. However, I don't recommend to call it in > production code ;-) > Is pprint not an opt

[apparmor] [PATCH] add /var/www/html to abstractions/web-data

2014-02-27 Thread Jamie Strandboge
This patch adds /var/www/html to abstractions/web-data, which is the path used for document root on Debian and its derivatives[1]. Nominated for 2.8. [1] The document root used to be /var/www for Debian and its derivatives, but this was changed recently. We could use /var/www, but I erred on t

[apparmor] [patch] Post merge test fixes

2014-02-27 Thread Kshitij Gupta
Hello, I ran the tests locally using apparmor/utils/test/runtests-py2.sh and ended up with a lot of broken tests. I've fixed the tests for the tools, which required adapting to new directory structure and fixing a couple of values. The following patch fixes them. However, I still get errors from