Re: [apparmor] [patch 16/26] Make dbus tests be conditionally run based on pkg-config

2014-04-17 Thread Seth Arnold
On Tue, Apr 15, 2014 at 10:22:23AM -0700, john.johan...@canonical.com wrote: > The addition of the dbus tests requires dbus dev libraries be installed > to run the test suite. This is not always desirable or even possible. > > So make building and running the dbus tests conditional on the > pkg-co

Re: [apparmor] [patch 15/26] Split dfa optimization and dump flag handling into a separate file so that it can be shared with DFA test programs

2014-04-17 Thread Seth Arnold
On Tue, Apr 15, 2014 at 10:22:22AM -0700, john.johan...@canonical.com wrote: > Signed-off-by: John Johansen > Acked-by: Seth Arnold > Acked-by: Steve Beattie Still acked-by, though a few notes: It's 2014 now whether or not we like it, I think all the copyright dates need to be updated. :) Also

Re: [apparmor] [patch 14/26] Convert to htoleXX fns instead of ifdef on endian

2014-04-17 Thread Seth Arnold
On Tue, Apr 15, 2014 at 10:22:21AM -0700, john.johan...@canonical.com wrote: > This patch makes use of the htoleXX() functions (see endian(3)) > defined as part of endian.h (already included in parser_interface.c), > instead of defining a function differently based on the detection of > endian rela

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

2014-04-17 Thread Seth Arnold
On Thu, Apr 17, 2014 at 10:48:07AM -0700, Steve Beattie wrote: > parser: find SIZE_MAX on older versions of glibc and g++ > > Another issue with commit 2456 is that with older versions of glibc and > g++, a definition for SIZE_MAX was not being found; e.g. on Ubuntu 12.04 > LTS and 12.10, the pars

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

2014-04-17 Thread John Johansen
On 04/17/2014 10:48 AM, Steve Beattie wrote: > parser: find SIZE_MAX on older versions of glibc and g++ > > Another issue with commit 2456 is that with older versions of glibc and > g++, a definition for SIZE_MAX was not being found; e.g. on Ubuntu 12.04 > LTS and 12.10, the parser fails to compil

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

2014-04-17 Thread Steve Beattie
parser: find SIZE_MAX on older versions of glibc and g++ Another issue with commit 2456 is that with older versions of glibc and g++, a definition for SIZE_MAX was not being found; e.g. on Ubuntu 12.04 LTS and 12.10, the parser fails to compile with the following error: g++ -g -O2 -pipe -Wall -