[apparmor] [PATCH 2/2] tests: Mount without updating mtab in mount.sh

2014-04-24 Thread Tyler Hicks
The mount.sh script mixes calls to the regression test 'mount' binary and /sbin/mount. This can result in stale mtab entries being left around after a test run because /sbin/mount adds an mtab entry but the test 'mount' binary, which is also used for unmounting, does not remove mtab entries. To

[apparmor] [patch] parser language tests: force using a features file

2014-04-24 Thread Steve Beattie
With the recent addition of features like ptrace and signals that give warnings and then ignore the subset of rules when the features directory indicates that the kernel does not support mediating such features, at least one of the language tests fails in a chroot environment where the apparmor

Re: [apparmor] [PATCH 2/2] tests: Mount without updating mtab in mount.sh

2014-04-24 Thread Steve Beattie
On Thu, Apr 24, 2014 at 01:06:06AM -0500, Tyler Hicks wrote: The mount.sh script mixes calls to the regression test 'mount' binary and /sbin/mount. This can result in stale mtab entries being left around after a test run because /sbin/mount adds an mtab entry but the test 'mount' binary, which

Re: [apparmor] [PATCH 1/2] tests: Fix mount.sh test error

2014-04-24 Thread Seth Arnold
On Thu, Apr 24, 2014 at 01:06:05AM -0500, Tyler Hicks wrote: The end of the mount.sh regression test script contained cleanup commands to unmount and detach the loop device used for testing. However, the second losetup command fails and, with the recent regression test suite fix to not ignore

Re: [apparmor] [PATCH 2/2] tests: Mount without updating mtab in mount.sh

2014-04-24 Thread Seth Arnold
On Thu, Apr 24, 2014 at 01:06:06AM -0500, Tyler Hicks wrote: The mount.sh script mixes calls to the regression test 'mount' binary and /sbin/mount. This can result in stale mtab entries being left around after a test run because /sbin/mount adds an mtab entry but the test 'mount' binary, which

Re: [apparmor] [patch] parser language tests: force using a features file

2014-04-24 Thread Seth Arnold
On Thu, Apr 24, 2014 at 12:09:42AM -0700, Steve Beattie wrote: With the recent addition of features like ptrace and signals that give warnings and then ignore the subset of rules when the features directory indicates that the kernel does not support mediating such features, at least one of the

Re: [apparmor] [patch] parser language tests: force using a features file

2014-04-24 Thread Steve Beattie
On Thu, Apr 24, 2014 at 12:06:14PM -0700, Seth Arnold wrote: On Thu, Apr 24, 2014 at 12:09:42AM -0700, Steve Beattie wrote: A simple python script is included that was used to generate the features file based on the current feature set. I'm not sure how to keep it up to date in an automated

Re: [apparmor] [patch] parser language tests: force using a features file

2014-04-24 Thread John Johansen
On 04/24/2014 12:27 PM, Steve Beattie wrote: On Thu, Apr 24, 2014 at 12:06:14PM -0700, Seth Arnold wrote: On Thu, Apr 24, 2014 at 12:09:42AM -0700, Steve Beattie wrote: A simple python script is included that was used to generate the features file based on the current feature set. I'm not sure