Re: [apparmor] [patch] raise exception if sub_str_to_mode() is called with invalid mode string (was: Re: [patch] add tests for aamode.py)

2015-02-02 Thread Steve Beattie
On Mon, Dec 22, 2014 at 07:24:19PM +0100, Christian Boltz wrote: Raise an exception if sub_str_to_mode() is called with invalid mode string or if a mode_char is not in MODE_HASH. Also update the testcase for asdf42 (which raises AppArmorBug now) and add a test that simulates MODE_HASH and

[apparmor] Fwd: Re: [pkg-apparmor] aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread u
Hi, (Cc:ed Peter Palfrader (weasel), who maintains tor in Debian and the Debian AppArmor Packaging Team.) While playing around with `aa-unconfined` i saw that /usr/bin/tor is marked as not being confined. In Debian, `tor` comes with an apparmor profile which is called system_tor and lives in

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread Steve Beattie
On Mon, Feb 02, 2015 at 10:22:27AM +, u wrote: (Cc:ed Peter Palfrader (weasel), who maintains tor in Debian and the Debian AppArmor Packaging Team.) While playing around with `aa-unconfined` i saw that /usr/bin/tor is marked as not being confined. In Debian, `tor` comes with an

Re: [apparmor] [Patch][parser] fix: globbing for af_unix abstract names

2015-02-02 Thread Steve Beattie
On Mon, Feb 02, 2015 at 01:28:55PM -0800, John Johansen wrote: On 01/30/2015 03:14 PM, John Johansen wrote: v2. per Christian's request on IRC grouping of the glob switch into a single fn I like moving the switch into a function as well. Acked-by: Steve Beattie st...@nxnw.org for both

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread u
Hi, Steve Beattie: On Mon, Feb 02, 2015 at 10:22:27AM +, u wrote: `aa-unconfined` seems to ignore this, but `aa-status` tells me that the `system_tor` profile is well active. This is a bug in aa-unconfined. It's not been updated to take into account the possibility of profile names

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread Christian Boltz
Hello, Am Montag, 2. Februar 2015 schrieb u: Christian Boltz: Am Montag, 2. Februar 2015 schrieb u: While playing around with `aa-unconfined` i saw that /usr/bin/tor is marked as not being confined. Does it work if you change aa-unconfined line 66? Untested pseudo-patch: -

Re: [apparmor] [Patch][parser] fix: globbing for af_unix abstract names

2015-02-02 Thread John Johansen
On 01/30/2015 03:14 PM, John Johansen wrote: v2. per Christian's request on IRC grouping of the glob switch into a single fn === modified file 'parser/af_unix.cc' --- parser/af_unix.cc 2014-10-08 20:20:20 + +++ parser/af_unix.cc 2015-01-30 17:46:36 + @@ -243,7 +243,7 @@

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread Christian Boltz
Hello, Am Montag, 2. Februar 2015 schrieb u: While playing around with `aa-unconfined` i saw that /usr/bin/tor is marked as not being confined. In Debian, `tor` comes with an apparmor profile which is called system_tor and lives in /etc/apparmor.d. `aa-unconfined` seems to ignore this,

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread John Johansen
On 02/02/2015 07:51 AM, Christian Boltz wrote: Hello, Am Montag, 2. Februar 2015 schrieb u: While playing around with `aa-unconfined` i saw that /usr/bin/tor is marked as not being confined. In Debian, `tor` comes with an apparmor profile which is called system_tor and lives in

[apparmor] [Merge] lp:~chkpnt/apparmor/ssl_certs into lp:apparmor

2015-02-02 Thread Gregor Dschung
Gregor Dschung has proposed merging lp:~chkpnt/apparmor/ssl_certs into lp:apparmor. Requested reviews: AppArmor Developers (apparmor-dev) For more details, see: https://code.launchpad.net/~chkpnt/apparmor/ssl_certs/+merge/248191 /etc/apparmor.d/abstractions/ssl_certs now contains entries for

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread Christian Boltz
Hello, Am Montag, 2. Februar 2015 schrieb John Johansen: On 02/02/2015 07:51 AM, Christian Boltz wrote: Does it work if you change aa-unconfined line 66? Untested pseudo-patch: -if line.startswith(/) or line.startswith(null): + if line.strip() !=

Re: [apparmor] [pkg-apparmor] Fwd: Re: aa-unconfined shows tor as being unconfined, aa-status says different

2015-02-02 Thread John Johansen
On 02/02/2015 10:58 AM, Christian Boltz wrote: Hello, Am Montag, 2. Februar 2015 schrieb u: Christian Boltz: Am Montag, 2. Februar 2015 schrieb u: While playing around with `aa-unconfined` i saw that /usr/bin/tor is marked as not being confined. Does it work if you change aa-unconfined