Re: [apparmor] apparmor query interface spec and changes

2015-02-09 Thread John Johansen
On 02/09/2015 05:44 AM, Christian Boltz wrote: Hello, I have some feedback and questions before the meeting tomorrow ;-) Am Freitag, 6. Februar 2015 schrieb John Johansen: Anyways profiles in the unconfined mode show up as profile (unconfined) while the current behavior of the

[apparmor] [PATCH 0/4] Clarify the terms context and label

2015-02-09 Thread Tyler Hicks
Last week, I realized that I haven't been correctly using the terms context and label. I've been interchanging them but they're two very distinct things as far as AppArmor is concerned. I think the source of my confusion is from our own documentation and code. These patches attempt to set the

[apparmor] [PATCH 4/4] tests: Update code to correctly use the terms context and label

2015-02-09 Thread Tyler Hicks
Signed-off-by: Tyler Hicks tyhi...@canonical.com --- tests/regression/apparmor/pivot_root.c | 30 +++--- tests/regression/apparmor/socketpair.c | 26 +- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git

[apparmor] [PATCH 1/4] libapparmor: Document the terms context and label in aa_getcon(2)

2015-02-09 Thread Tyler Hicks
The correct usage of the terms context and label is not clear in the aa_getcon(2) man page. The aa_getcon(2) family of functions are also prototyped incorrectly since the *con parameter represents a label and not a context. Signed-off-by: Tyler Hicks tyhi...@canonical.com ---

[apparmor] [PATCH 3/4] mod_apparmor: Update code to correctly use the terms context and label

2015-02-09 Thread Tyler Hicks
Signed-off-by: Tyler Hicks tyhi...@canonical.com --- changehat/mod_apparmor/mod_apparmor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/changehat/mod_apparmor/mod_apparmor.c b/changehat/mod_apparmor/mod_apparmor.c index 219ee6d..e3a8fea 100644 ---

[apparmor] [PATCH 2/4] libapparmor: Update code to correctly use the terms context and label

2015-02-09 Thread Tyler Hicks
Adjust the libapparmor function prototypes, variable names, and comments that incorrectly used the name con when referring to the label. Signed-off-by: Tyler Hicks tyhi...@canonical.com --- libraries/libapparmor/include/sys/apparmor.h | 9 ++- libraries/libapparmor/src/kernel_interface.c |

Re: [apparmor] apparmor query interface spec and changes

2015-02-09 Thread Christian Boltz
Hello, I have some feedback and questions before the meeting tomorrow ;-) Am Freitag, 6. Februar 2015 schrieb John Johansen: Anyways profiles in the unconfined mode show up as profile (unconfined) while the current behavior of the unconfined profile, which is the standard default profile

Re: [apparmor] [PATCH 2/4] libapparmor: Update code to correctly use the terms context and label

2015-02-09 Thread John Johansen
On 02/09/2015 02:37 PM, Tyler Hicks wrote: Adjust the libapparmor function prototypes, variable names, and comments that incorrectly used the name con when referring to the label. Signed-off-by: Tyler Hicks tyhi...@canonical.com Acked-by: John Johansen john.johan...@canonical.com ---

Re: [apparmor] [PATCH 4/4] tests: Update code to correctly use the terms context and label

2015-02-09 Thread Tyler Hicks
There are two things that I missed, mentioned below. I've made these changes locally. On 2015-02-09 16:37:59, Tyler Hicks wrote: Signed-off-by: Tyler Hicks tyhi...@canonical.com --- tests/regression/apparmor/pivot_root.c | 30 +++---

Re: [apparmor] [PATCH 3/4] mod_apparmor: Update code to correctly use the terms context and label

2015-02-09 Thread John Johansen
On 02/09/2015 02:37 PM, Tyler Hicks wrote: Signed-off-by: Tyler Hicks tyhi...@canonical.com Acked-by: John Johansen john.johan...@canonical.com --- changehat/mod_apparmor/mod_apparmor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [apparmor] [PATCH 4/4] tests: Update code to correctly use the terms context and label

2015-02-09 Thread John Johansen
On 02/09/2015 04:06 PM, Tyler Hicks wrote: There are two things that I missed, mentioned below. I've made these changes locally. Arguable whether the profile change was needed, but I'm not arguing against making the change. It looks good, thanks Acked-by: John Johansen

Re: [apparmor] [PATCH 1/4] libapparmor: Document the terms context and label in aa_getcon(2)

2015-02-09 Thread John Johansen
On 02/09/2015 02:37 PM, Tyler Hicks wrote: The correct usage of the terms context and label is not clear in the aa_getcon(2) man page. The aa_getcon(2) family of functions are also prototyped incorrectly since the *con parameter represents a label and not a context. Signed-off-by: Tyler

Re: [apparmor] [PATCH 0/4] Clarify the terms context and label

2015-02-09 Thread Tyler Hicks
On 2015-02-09 16:37:55, Tyler Hicks wrote: Last week, I realized that I haven't been correctly using the terms context and label. I've been interchanging them but they're two very distinct things as far as AppArmor is concerned. I think the source of my confusion is from our own