Re: [apparmor] [PATCH v2 05/42] split the policy cache handling fns into their own file

2015-03-12 Thread Seth Arnold
On Wed, Mar 11, 2015 at 07:53:45PM -0700, Seth Arnold wrote: > On Fri, Mar 06, 2015 at 03:48:21PM -0600, Tyler Hicks wrote: > > From: John Johansen > > > > Signed-off-by: John Johansen > > [tyhicks: Don't move globals in favor of lifting those out later] > > Signed-off-by: Tyler Hicks > Acked

Re: [apparmor] [PATCH] fixup! split the policy cache handling fns into their own file

2015-03-12 Thread Seth Arnold
On Thu, Mar 12, 2015 at 05:45:00PM -0500, Tyler Hicks wrote: > Make policy_cache.o depend on lib.h > > Signed-off-by: Tyler Hicks Acked-by: Seth Arnold Thanks > --- > parser/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parser/Makefile b/parser/Makefile >

Re: [apparmor] [PATCH] fixup! split the policy cache handling fns into their own file

2015-03-12 Thread Steve Beattie
On Thu, Mar 12, 2015 at 05:45:00PM -0500, Tyler Hicks wrote: > Make policy_cache.o depend on lib.h > > Signed-off-by: Tyler Hicks Acked-by: Steve Beattie > --- > parser/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parser/Makefile b/parser/Makefile > index

Re: [apparmor] [PATCH] fixup! split the policy cache handling fns into their own file

2015-03-12 Thread John Johansen
On 03/12/2015 03:45 PM, Tyler Hicks wrote: > Make policy_cache.o depend on lib.h > > Signed-off-by: Tyler Hicks Acked-by: John Johansen > --- > parser/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/parser/Makefile b/parser/Makefile > index 9175a30..7b8e85d 1

[apparmor] [PATCH] fixup! split the policy cache handling fns into their own file

2015-03-12 Thread Tyler Hicks
Make policy_cache.o depend on lib.h Signed-off-by: Tyler Hicks --- parser/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parser/Makefile b/parser/Makefile index 9175a30..7b8e85d 100644 --- a/parser/Makefile +++ b/parser/Makefile @@ -239,7 +239,7 @@ common_optarg.o:

Re: [apparmor] [PATCH v2 21/42] parser: Add functions for features support tests

2015-03-12 Thread Tyler Hicks
On 2015-03-12 04:17:56, John Johansen wrote: > On 03/06/2015 01:48 PM, Tyler Hicks wrote: > > Defines a function that can be called to test features support. It is > > string based which allows the support tests to work with new kernel > > features without any changes. > > > > The use of global va

Re: [apparmor] [PATCH] fixup! libapparmor: Move the aa_features API

2015-03-12 Thread John Johansen
On 03/12/2015 02:47 PM, Tyler Hicks wrote: > Correct the export map. > > Signed-off-by: Tyler Hicks this and the preceeding patch it fixes Acked-by: John Johansen > --- > libraries/libapparmor/src/libapparmor.map | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --

[apparmor] [PATCH] fixup! libapparmor: Move the aa_features API

2015-03-12 Thread Tyler Hicks
Correct the export map. Signed-off-by: Tyler Hicks --- libraries/libapparmor/src/libapparmor.map | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libraries/libapparmor/src/libapparmor.map b/libraries/libapparmor/src/libapparmor.map index d0020c7..e61a314 100644 --

Re: [apparmor] [PATCH v2 36/42] libapparmor: Move the aa_features API

2015-03-12 Thread Tyler Hicks
On 2015-03-12 05:03:49, John Johansen wrote: > On 03/06/2015 01:48 PM, Tyler Hicks wrote: > > Signed-off-by: Tyler Hicks > > --- > > libraries/libapparmor/include/sys/apparmor.h | 13 + > > libraries/libapparmor/src/Makefile.am| 2 +- > > libraries/libapparmor/src/features.c |

Re: [apparmor] [PATCH v2 30/42] libapparmor: Create a private API

2015-03-12 Thread Christian Boltz
Hello, Am Donnerstag, 12. März 2015 schrieb John Johansen: > On 03/09/2015 05:52 PM, Christian Boltz wrote: > > (I'm quite sure I mentioned this difference already, but since there > > is > yes you did, multiple times, and I am sure you will continue to keep > us from letting this slip through the

Re: [apparmor] [PATCH v2 38/42] libapparmor: Move the aa_kernel_interface API

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > Signed-off-by: Tyler Hicks Acked-by: John Johansen > --- > libraries/libapparmor/include/sys/apparmor.h | 23 ++ > libraries/libapparmor/src/Makefile.am| 2 +- > libraries/libapparmor/src/kernel_interface.c | 393 ++

Re: [apparmor] [PATCH v2 39/42] libapparmor: Add macro for the gcc "unused" attribute

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > As code is moved from the parser to libapparmor, the libapparmor code > base will need to have the "unused" macro defined. This macro will need > to be duplicated in the parser and libapparmor due to it being a > compiler-specific macro that shouldn't be

Re: [apparmor] [PATCH v2 42/42] parser: Remove atomic ops

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > The parser no longer has a need for the atomic operations since all > callers have been moved to libapparmor. > > Signed-off-by: Tyler Hicks Acked-by: John Johansen > --- > parser/lib.c | 10 -- > parser/lib.h | 3 --- > 2 files changed, 13

Re: [apparmor] [PATCH v2 41/42] libapparmor: Move the aa_policy_cache API

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > Signed-off-by: Tyler Hicks Acked-by: John Johansen > --- > libraries/libapparmor/include/sys/apparmor.h | 13 ++ > libraries/libapparmor/src/Makefile.am| 2 +- > libraries/libapparmor/src/libapparmor.map| 7 + > libraries/libapparmor

Re: [apparmor] [PATCH v2 40/42] parser: Lift globals from create_cache()

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > With create_cache() headed for libapparmor, we can't use the show_cache > or write_cache globals. > > Signed-off-by: Tyler Hicks Acked-by: John Johansen > --- > parser/parser_main.c | 4 > parser/policy_cache.c | 20 ++-- > 2

Re: [apparmor] [PATCH v2 35/42] parser: Don't use gettext(3) in code that will be moved to libapparmor

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > Remove the use of the "_" macro, which translates into gettext(3), from > code that will be used from the parser to libapparmor since libapparmor > will not support gettext(3) for debug messages and syslog messages. > > Signed-off-by: Tyler Hicks Acked

Re: [apparmor] [PATCH v2 21/42] parser: Add functions for features support tests

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > Defines a function that can be called to test features support. It is > string based which allows the support tests to work with new kernel > features without any changes. > > The use of global variables in the parser to store and check features > suppo

Re: [apparmor] [PATCH v2 00/42] Create libapparmor API for policy cache loading

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > This patch set creates a libapparmor API to allow for in-process AppArmor > policy cache loading. At the moment, this API will be useful for > apparmor_parser and systemd. > > I've combined two different proposed patch sets[1][2] into one since they bot

Re: [apparmor] [PATCH v2 36/42] libapparmor: Move the aa_features API

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > Signed-off-by: Tyler Hicks > --- > libraries/libapparmor/include/sys/apparmor.h | 13 + > libraries/libapparmor/src/Makefile.am| 2 +- > libraries/libapparmor/src/features.c | 448 > +++ > libraries/libapparm

Re: [apparmor] [PATCH v2 32/42] libapparmor: Add basic logging functionality

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > This patch adds equivalents of the parser's PDEBUG() and PERROR() > functions to libapparmor. > > It does not add gettext(3) support to libapparmor since these are > messages that only developers will see (debug builds with > LIBAPPARMOR_DEBUG=1) or mes

Re: [apparmor] [PATCH v2 30/42] libapparmor: Create a private API

2015-03-12 Thread John Johansen
On 03/09/2015 05:52 PM, Christian Boltz wrote: > Hello, > > Am Freitag, 6. März 2015 schrieb Tyler Hicks: >> To kick things off, a library friendly version of is_blacklisted() is >> moved into libapparmor. > > I know you are only moving code around, but: > > There's a little difference to the fi

Re: [apparmor] [PATCH v2 17/42] parser: Clean up snprintf_buffer()

2015-03-12 Thread John Johansen
On 03/06/2015 01:48 PM, Tyler Hicks wrote: > snprintf_buffer() needed to be modified in order to properly return error > conditions up the stack, instead of exiting, but there were some other > cleanups that it could use. > > It was obviously implemented with the features_struct in mind so this >

Re: [apparmor] [PATCH v2 01/42] parser: Honor USE_SYSTEM make variable in libapparmor_re

2015-03-12 Thread Steve Beattie
On Fri, Mar 06, 2015 at 03:48:17PM -0600, Tyler Hicks wrote: > Signed-off-by: Tyler Hicks > Acked-by: Seth Arnold Acked-by: Steve Beattie > --- > parser/libapparmor_re/Makefile | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/parser/libapparmor_re/Makefile b/pa