[apparmor] [PATCH v2 46/42] tests: Add regression tests for the aa_policy_cache API

2015-03-25 Thread Tyler Hicks
The aa_features and aa_kernel_interface APIs get a little bit of testing, as well. Signed-off-by: Tyler Hicks tyhi...@canonical.com --- tests/regression/apparmor/Makefile | 17 ++ tests/regression/apparmor/aa_policy_cache.c | 228 +++

[apparmor] [PATCH 1/3] apparmor.d.pod: create RULES grouping and cleanup profile PROFILE rule

2015-03-25 Thread John Johansen
Signed-off-by: John Johansen john.johan...@canonical.com --- parser/apparmor.d.pod | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/parser/apparmor.d.pod b/parser/apparmor.d.pod index 1cb3b6e..3b4e4e9 100644 --- a/parser/apparmor.d.pod +++ b/parser/apparmor.d.pod @@

[apparmor] [Patch 0/3] v2 of more apparmor.d.pod cleanups

2015-03-25 Thread John Johansen
I believe this series addresses all the issues that Christian raised when commenting on the last set of patches (https://lists.ubuntu.com/archives/apparmor/2015-March/007509.html). - Specifically the rules are grouped and cleaned up - RESOURCE RULE is removed - ALIAS RULE is added to the rules

[apparmor] [PATCH 4/6] libapparmor: Improve documentation of aa_policy_cache_replace_all()

2015-03-25 Thread Tyler Hicks
Document that the kernel_interface parameter is optional. Signed-off-by: Tyler Hicks tyhi...@canonical.com --- libraries/libapparmor/src/policy_cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/libapparmor/src/policy_cache.c b/libraries/libapparmor/src/policy_cache.c index

Re: [apparmor] [PATCH 3/6] libapparmor: Adjust some aa_policy_cache function comments

2015-03-25 Thread Steve Beattie
On Wed, Mar 25, 2015 at 05:37:18PM -0500, Tyler Hicks wrote: The aa_features object that is passed to aa_policy_cache_new() does not have to represent the currently running kernel. It may represent a different kernel, such as a kernel that was just installed, that is not currently running.

Re: [apparmor] [PATCH 1/6] libapparmor: Fix memory leak when freeing aa_policy_cache objects

2015-03-25 Thread Steve Beattie
On Wed, Mar 25, 2015 at 05:37:16PM -0500, Tyler Hicks wrote: The two internal aa_features objects weren't being unreferenced when the aa_policy_cache object was being freed. Signed-off-by: Tyler Hicks tyhi...@canonical.com Acked-by: Steve Beattie st...@nxnw.org Thanks. ---