Re: [apparmor] [patch] Fix crash in serialize_profile_from_old_profiles()

2015-04-08 Thread Seth Arnold
On Thu, Apr 09, 2015 at 12:04:13AM +0200, Christian Boltz wrote: > > The patch wraps the hasher usage with a check for the parent element to > avoid auto-creation of empty childs, which then lead to the above crash. This also changes the indent level of two of the tests -- is that intentional? T

Re: [apparmor] [patch] Fix writing network rules

2015-04-08 Thread Seth Arnold
On Wed, Apr 08, 2015 at 10:38:03PM +0200, Christian Boltz wrote: > Hello, > > sometimes fixing a bug is easy ;-) > > write_net_rules() creates invalid rules for network rules with one > parameter (for example "network bluetooth"). > Add a trailing comma to create valid rules. > > This is another

[apparmor] [patch] Fix crash in serialize_profile_from_old_profiles()

2015-04-08 Thread Christian Boltz
Hello, Assume you have a profile like /bin/foo { /etc/ r, network, /usr/ r, } (important: there must be be a non-path rule between the two path blocks) Then run aa-logprof and add another path event. When choosing (V)iew changes, it will crash with a misleading File

[apparmor] [patch] Fix serialize_profile_from_old_profiles() to not crash on "@{var} +="

2015-04-08 Thread Christian Boltz
Hello, serialize_profile_from_old_profiles() calls store_list_var() with an empty hasher. This fails for "+=" because in this case store_list_var() expects a non-empty hasher with the variable already defined, and raises an exception because of the empty hasher. This patch sets "correct = False"

[apparmor] [patch] Fix writing network rules

2015-04-08 Thread Christian Boltz
Hello, sometimes fixing a bug is easy ;-) write_net_rules() creates invalid rules for network rules with one parameter (for example "network bluetooth"). Add a trailing comma to create valid rules. This is another bug uncovered by playing with the LibreOffice profile ("why does the profile have

Re: [apparmor] [patch] allow ubuntu-helpers to generate texlive fonts (LP: #1010909)

2015-04-08 Thread Jamie Strandboge
On 04/07/2015 04:51 PM, Steve Beattie wrote: > Bug: https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/1010909 > > When evince opens a dvi file, it updates the user fonts using > texlive commands in /usr/share/texlive/texmf-dist/web2c/ (or possibly > /usr/share/texlive/texmf/web2c/ in older r