Re: [apparmor] [patch 3/3] Convert existing code to use NetworkRule and NetworkRuleset

Hello, Am Montag, 20. April 2015 schrieb Kshitij Gupta: > Strange. The ordering of added and removed lines changed between the 2 > versions of the patches. That might be caused by a different method to create the patch. Not everything that looks like "bzr diff" output is actually bzr diff outpu

Re: [apparmor] [patch 2/3] Add tests for NetworkRule and NetworkRuleset

Hello, Am Montag, 20. April 2015 schrieb Kshitij Gupta: > On Mon, Apr 20, 2015 at 3:59 AM, Christian Boltz wrote: > > Am Sonntag, 19. April 2015 schrieb Kshitij Gupta: > > > On Sat, Apr 18, 2015 at 2:51 AM, Christian Boltz wrote: > > Hmm, that's an interesting question. > > > > While I agree tha

Re: [apparmor] [patch] Move test_parse_modifiers_invalid() to test-baserule.py

Hello, On Mon, Apr 20, 2015 at 3:07 AM, Christian Boltz wrote: > Hello, > > test_parse_modifiers_invalid() uses a hand-broken ;-) regex to parse > only the allow/deny/audit keywords. This test applies to all rule types > and doesn't contain anything specific to capability or other rules, > there

Re: [apparmor] [patch] Add tests for Baserule

Hello, On Sun, Apr 12, 2015 at 2:32 AM, Christian Boltz wrote: > Hello, > > This patch adds some tests for the Baserule class to cover the > 3 functions that must be re-implemented in each rule class. This means > we finally get 100% test coverage for apparmor/rule/__init__.py ;-) > > 100% cover