Re: [apparmor] AppArmor 2.10 branch created

2015-11-18 Thread John Johansen
On 11/18/2015 04:51 AM, Christian Boltz wrote: > Hello, > > Am Mittwoch, 18. November 2015 schrieb Steve Beattie: >> After the discussion in the IRC meeting yesterday and in preparation >> for upcoming AppArmor 2.10.1 and 2.11 releases, I have created the >> apparmor 2.10 branch on launchpad: >

Re: [apparmor] [patch] update PYMODULES in tools/Makefile

2015-11-18 Thread Kshitij Gupta
Thanks for the patch. Acked-by: Kshitij Gupta for trunk and 2.10 On Wed, Oct 28, 2015 at 2:19 AM, Christian Boltz wrote: > Hello, > > PYMODULES is used for generating *.pod, so it should include rule/*.py > > > [ utils-Makefile-pymodules.diff ] > >

Re: [apparmor] 2.9 backport candidates

2015-11-18 Thread Christian Boltz
Hello, Am Dienstag, 17. November 2015 schrieb John Johansen: > I'm fine with pulling this set back into the tools > > Acked-by: John Johansen Thanks, commited. Well, there's one exception: > >> ==> 10-tests-tempdir.msg <== > >> Add tempdir and tempfile handling

Re: [apparmor] [patch] Fix parsing/storing bare file rules

2015-11-18 Thread Kshitij Gupta
On Wed, Oct 28, 2015 at 4:15 AM, Christian Boltz wrote: > Hello, > > we replaced parse_audit_allow() with parse_modifiers() in r2833, but > overlooked that parse_modifiers() returns allow/deny as boolean. This > resulted in storing bare file rules in

Re: [apparmor] [patch] Fix parsing/storing bare file rules

2015-11-18 Thread Christian Boltz
Hello, Am Donnerstag, 19. November 2015 schrieb Kshitij Gupta: > On Wed, Oct 28, 2015 at 4:15 AM, Christian Boltz wrote: ... > > BTW: I noticed this while playing with a more strict > > profile_storage() that uses more dict()s instead of a big hasher() > > monster. > > *stricter*

Re: [apparmor] [patch] utils/test/Makefile: add libapparmor to PYTHONPATH

2015-11-18 Thread John Johansen
On 10/21/2015 03:02 PM, Christian Boltz wrote: > Hello, > > the last utils/test/Makefile change switched to using the in-tree > libapparmor by default (unless USE_SYSTEM=1 is given). However, I missed > to add the swig/python parts of libapparmor to PYTHONPATH, so the > system-wide

Re: [apparmor] AppArmor 2.10 branch created

2015-11-18 Thread Christian Boltz
Hello, Am Mittwoch, 18. November 2015 schrieb Steve Beattie: > After the discussion in the IRC meeting yesterday and in preparation > for upcoming AppArmor 2.10.1 and 2.11 releases, I have created the > apparmor 2.10 branch on launchpad: I hereby nominate all my pending patches for 2.10 ;-)

Re: [apparmor] [patch] Add debug info to profile_storage()

2015-11-18 Thread John Johansen
On 10/21/2015 01:53 PM, Christian Boltz wrote: > Hello, > > Am Dienstag, 20. Oktober 2015 schrieb John Johansen: >> On 07/20/2015 12:22 PM, Christian Boltz wrote: >>> for debugging, it's helpful to know which part of the code >>> initialized a profile_storage and for which profile and hat this

Re: [apparmor] [patch] add a named match group to RE_PROFILE_SIGNAL

2015-11-18 Thread John Johansen
On 10/22/2015 04:38 PM, Christian Boltz wrote: > Hello, > > as a preparation for the SignalRule class, add a match group > to RE_PROFILE_SIGNAL. > > Also adjust test-regex_matches.py for the added group. > > Note: RE_PROFILE_SIGNAL is only used in aa.py, and only matches[0..2] > are used. 0

[apparmor] AppArmor 2.10 branch created

2015-11-18 Thread Steve Beattie
After the discussion in the IRC meeting yesterday and in preparation for upcoming AppArmor 2.10.1 and 2.11 releases, I have created the apparmor 2.10 branch on launchpad: https://code.launchpad.net/~apparmor-dev/apparmor/2.10 People who like to receive emails when commits are made to that

[apparmor] Fwd: [patch] Change aa.py to use SignalRule and SignalRuleset

2015-11-18 Thread Kshitij Gupta
On Fri, Oct 23, 2015 at 6:51 PM, Christian Boltz wrote: > Hello, > > this patch changes aa.py to use SignalRule and SignalRuleset. > > This means: > - import the classes instead of RE_PROFILE_SIGNAL > - simplify signal rule parsing a lot > - drop the (now unused) functions

Re: [apparmor] [patch] Add SignalRule and SignalRuleset classes

2015-11-18 Thread Kshitij Gupta
For: [ 13-test-signal-compare_obj.diff ] [ 17-signal-rule-cleanup.diff ] [ 21-test-signal-rename-tests.diff ] Acked-by: Kshitij Gupta On Tue, Nov 17, 2015 at 2:23 AM, Christian Boltz wrote: > Hello, > > Am Freitag, 23. Oktober 2015 schrieb Christian

Re: [apparmor] [patch] Add support for rlimit and signal rules to aa-mergeprof

2015-11-18 Thread Kshitij Gupta
On Fri, Oct 23, 2015 at 9:04 PM, Christian Boltz wrote: > Hello, > > $subject ;-) > > > [ 11-mergeprof-support-rlimit-and-signal.diff ] > > --- utils/aa-mergeprof 2015-06-25 21:32:37.420831338 +0200 > +++ utils/aa-mergeprof 2015-10-23 17:26:03.947428725 +0200 > @@ -631,7

Re: [apparmor] [patch] Move all tests from test-signal_parse.py to test-signal.py

2015-11-18 Thread Kshitij Gupta
On Sat, Oct 24, 2015 at 6:18 PM, Christian Boltz wrote: > Hello, > > it's pointless to keep a separate file for those tests - they integrate > well in test-signal.py. > > After the move, test-signal_parse.py is empty and will be deleted. > > > [

Re: [apparmor] [patch] Update cleanprof to also delete superfluous signal etc. rules

2015-11-18 Thread Kshitij Gupta
On Fri, Oct 23, 2015 at 8:51 PM, Christian Boltz wrote: > Hello, > > besides 'signal', also 'change_profile' and 'rlimit' cleanup was missing > for the main profile. > > In aa.py delete_duplicates() (used to check includes), only 'signal' was > missing. > > > > [

Re: [apparmor] [patch] Change aa.py to use SignalRule and SignalRuleset

2015-11-18 Thread Kshitij Gupta
Accidentally hit reply instead of reply all. Lets see if this goes through. On Thu, Nov 19, 2015 at 3:50 AM, Kshitij Gupta wrote: > > > On Fri, Oct 23, 2015 at 6:51 PM, Christian Boltz > wrote: > >> Hello, >> >> this patch changes aa.py to use

Re: [apparmor] [PATCH] fix-abstraction-for-python3.5.patch

2015-11-18 Thread Christian Boltz
Hello, Am Mittwoch, 18. November 2015 schrieb Jamie Strandboge: > Description: update python abstraction for python 3.5 > > Signed-off-by: Jamie Strandboge I'd prefer a more future-proof version, which means to use python{2.[4-7],3.[0-9]} in all rules ;-) With or

Re: [apparmor] [patch] Adjust test-signal_parse.py to use SignalRule

2015-11-18 Thread Kshitij Gupta
On Fri, Oct 23, 2015 at 6:43 PM, Christian Boltz wrote: > Hello, > > the tests in test-signal_parse.py used aa.parse_signal_rule(), which is > based on Raw_Signal_Rule (= regex check + "just store it"). > > This patch changes the tests to test against SignalRule.get_clean().

[apparmor] [PATCH] fix-abstraction-for-python3.5.patch

2015-11-18 Thread Jamie Strandboge
Description: update python abstraction for python 3.5 Signed-off-by: Jamie Strandboge -- Jamie Strandboge http://www.ubuntu.com/ Author: Jamie Strandboge Description: update python abstraction for python 3.5 Index: