[apparmor] [patch] Fix a missing comma in parser_misc.c capnames

2016-01-15 Thread Christian Boltz
Hello, the capnames list missed a comma, which lead to the funny "mac_overridesyslog" capability name. __debug_capabilities() seems to be the only user of capnames, which might explain why this bug wasn't noticed earlier. I propose this patch for trunk, 2.10 and 2.9. BTW: Do we really need

Re: [apparmor] [PATCH] Fix: segfault when processing directories

2016-01-15 Thread Christian Boltz
Hello, Am Donnerstag, 14. Januar 2016 schrieb John Johansen: > On 01/14/2016 04:57 PM, Steve Beattie wrote: > > On Thu, Jan 14, 2016 at 04:46:36PM -0800, John Johansen wrote: > >> Patch -r 2952 switched over to using the library kernel interface, > >> and added a kernel_interface parameter to the

Re: [apparmor] [patch] Fix Coverity issue 56025 -- Uninitialized scalar field

2016-01-15 Thread Seth Arnold
On Fri, Jan 15, 2016 at 07:10:43PM -0800, Seth Arnold wrote: > public: > - Node(): nullable(false) { child[0] = child[1] = 0; } > + Node(): nullable(false), label(0) { child[0] = child[1] = 0; } > Node(Node *left): nullable(false) > { > child[0] = left; >

[apparmor] [patch] Fix Coverity issue 56025 -- Uninitialized scalar field

2016-01-15 Thread Seth Arnold
Coverity issue "56025 Uninitialized scalar field" reports the 'label' member of class Node may be used uninitialized. While this is a debugging-only integer and may be a false positive in actual use, the fix should be easy and remove an issue from our dashboard: Signed-off-by: Seth Arnold

Re: [apparmor] [patch] Fix a missing comma in parser_misc.c capnames

2016-01-15 Thread Seth Arnold
On Fri, Jan 15, 2016 at 01:34:58PM +0100, Christian Boltz wrote: > Hello, > > the capnames list missed a comma, which lead to the funny > "mac_overridesyslog" capability name. > > __debug_capabilities() seems to be the only user of capnames, which > might explain why this bug wasn't noticed

Re: [apparmor] [patch] Fix Coverity issue 56025 -- Uninitialized scalar field

2016-01-15 Thread John Johansen
On 01/15/2016 07:24 PM, Seth Arnold wrote: > On Fri, Jan 15, 2016 at 07:10:43PM -0800, Seth Arnold wrote: >> public: >> -Node(): nullable(false) { child[0] = child[1] = 0; } >> +Node(): nullable(false), label(0) { child[0] = child[1] = 0; } >> Node(Node *left): nullable(false) >>