Re: [apparmor] [PATCH 2/2] libapparmor: Don't print shell commands that check for test failures

2017-04-20 Thread John Johansen
On 04/20/2017 12:32 PM, Tyler Hicks wrote: > On 04/20/2017 02:28 PM, Tyler Hicks wrote: >> Error messages shouldn't show up in build logs when the error has been >> encountered. This patch silences these shell commands from being printed >> before they're interpreted. > > Typo in the first sentenc

Re: [apparmor] [PATCH 1/2] libapparmor: Fix parallel make dependency issue in testsuite

2017-04-20 Thread John Johansen
On 04/20/2017 12:28 PM, Tyler Hicks wrote: > A multi job `make check` command could fail due to check-local running > before the check-DEJAGNU target, which is automatically generated by > automake, would complete. This would result in a build failure due to > libaalogparse.log not yet existing. >

Re: [apparmor] [PATCH 2/2] libapparmor: Don't print shell commands that check for test failures

2017-04-20 Thread Christian Boltz
Hello, Am Donnerstag, 20. April 2017, 21:32:41 CEST schrieb Tyler Hicks: > On 04/20/2017 02:28 PM, Tyler Hicks wrote: > > Error messages shouldn't show up in build logs when the error has > > been encountered. This patch silences these shell commands from > > being printed before they're interpret

Re: [apparmor] [PATCH 2/2] libapparmor: Don't print shell commands that check for test failures

2017-04-20 Thread Tyler Hicks
On 04/20/2017 02:28 PM, Tyler Hicks wrote: > Error messages shouldn't show up in build logs when the error has been > encountered. This patch silences these shell commands from being printed > before they're interpreted. Typo in the first sentence above. Changed locally to: "Error messages should

[apparmor] [PATCH 1/2] libapparmor: Fix parallel make dependency issue in testsuite

2017-04-20 Thread Tyler Hicks
A multi job `make check` command could fail due to check-local running before the check-DEJAGNU target, which is automatically generated by automake, would complete. This would result in a build failure due to libaalogparse.log not yet existing. Fix the issue by depending on the check-DEJAGNU targ

[apparmor] [PATCH 2/2] libapparmor: Don't print shell commands that check for test failures

2017-04-20 Thread Tyler Hicks
Error messages shouldn't show up in build logs when the error has been encountered. This patch silences these shell commands from being printed before they're interpreted. Signed-off-by: Tyler Hicks --- libraries/libapparmor/testsuite/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

Re: [apparmor] [patch] Ignore test failures about duplicated conditionals in dbus rules

2017-04-20 Thread Tyler Hicks
On 04/15/2017 05:54 PM, Christian Boltz wrote: > Hello, > > Any comments or reviews on this patch? > > If nobody objects, I'll commit it (to trunk and 2.11) on Wednesday as > Acked-by . I see that the review period timed out already. That's fine by me as the change looks correct. Sorry that nob

Re: [apparmor] www.apparmor.net broken

2017-04-20 Thread John Johansen
On 04/15/2017 04:41 PM, Christian Boltz wrote: > Hello, > > sorting some old mails sometimes leads to interesting reminders... > > Am Montag, 11. Januar 2016, 11:16:40 CEST schrieb John Johansen: >> On 01/10/2016 11:06 AM, Christian Boltz wrote: > >>> http://www.apparmor.net/ -> "Forbidden" >> >