Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-11-05 Thread intrigeri
Review: Approve It seems something went wrong: John marked this as merged but apparently it was not, so I just merged it myself (+ applied the same change to 18.04): https://gitlab.com/apparmor/apparmor-profiles/commit/5ecd985737ca1e1bb6954525dfc1a405f1fe16b7. -- https://code.launchpad.net/~tal

[apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-10-23 Thread John Johansen
The proposal to merge ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~talkless/apparmor-profiles/+git/apparmor-profiles/+merge/331617 -- Your team

Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-10-23 Thread intrigeri
Review: Approve LGTM -- https://code.launchpad.net/~talkless/apparmor-profiles/+git/apparmor-profiles/+merge/331617 Your team AppArmor Developers is requested to review the proposed merge of ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master. -- AppArmo

Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-10-23 Thread Vincas Dargis
> I see that abstractions/ubuntu-browsers.d/java has something about > IcedTeaPlugin.so + other potentially useful stuff like access to > /{,var/}run/user/*/icedteaplugin-*/, that I suspect we'll need for Thunderbird > as well sooner or later. So how about including this abstraction instead? Done,

Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-10-23 Thread Vincas Dargis
OK I'm on it. -- https://code.launchpad.net/~talkless/apparmor-profiles/+git/apparmor-profiles/+merge/331617 Your team AppArmor Developers is requested to review the proposed merge of ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master. -- AppArmor mailin

Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-10-23 Thread intrigeri
Review: Needs Information I see that abstractions/ubuntu-browsers.d/java has something about IcedTeaPlugin.so + other potentially useful stuff like access to /{,var/}run/user/*/icedteaplugin-*/, that I suspect we'll need for Thunderbird as well sooner or later. So how about including this abstr

Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-09-30 Thread Vincas Dargis
> LGTM but would you mind making those rules "rm" to make the read access > explicit. Done. -- https://code.launchpad.net/~talkless/apparmor-profiles/+git/apparmor-profiles/+merge/331617 Your team AppArmor Developers is requested to review the proposed merge of ~talkless/apparmor-profiles:thunde

Re: [apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-09-30 Thread Simon Déziel
LGTM but would you mind making those rules "rm" to make the read access explicit. -- https://code.launchpad.net/~talkless/apparmor-profiles/+git/apparmor-profiles/+merge/331617 Your team AppArmor Developers is requested to review the proposed merge of ~talkless/apparmor-profiles:thunderbird-mozi

[apparmor] [Merge] ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master

2017-09-30 Thread Vincas Dargis
Vincas Dargis has proposed merging ~talkless/apparmor-profiles:thunderbird-mozilla-java-plugins into apparmor-profiles:master. Requested reviews: simon123 (simon-deziel) AppArmor Developers (apparmor-dev) For more details, see: https://code.launchpad.net/~talkless/apparmor-profiles/+git/app