Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-23 Thread Tyler Hicks
On 2013-12-23 13:10:01, Steve Beattie wrote: > On Fri, Dec 20, 2013 at 11:40:13PM -0800, Seth Arnold wrote: > > On Fri, Dec 20, 2013 at 11:06:26PM -0800, Steve Beattie wrote: > > > Ah, that's a very good point. I don't object to this approach for > > > the parser. Another solution would be to move

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-23 Thread Steve Beattie
On Fri, Dec 20, 2013 at 11:40:13PM -0800, Seth Arnold wrote: > On Fri, Dec 20, 2013 at 11:06:26PM -0800, Steve Beattie wrote: > > Ah, that's a very good point. I don't object to this approach for > > the parser. Another solution would be to move the public facing > > headers outside of the src/ tre

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-21 Thread John Johansen
On 12/20/2013 11:06 PM, Steve Beattie wrote: > On Tue, Dec 10, 2013 at 01:36:10PM -0800, Seth Arnold wrote: >> Is building against the in-tree version the "best" default? > > Yes. If there's been any development of the parser that depends on > features of libapparmor that are newer than your syste

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-20 Thread Seth Arnold
On Fri, Dec 20, 2013 at 11:06:26PM -0800, Steve Beattie wrote: > On Tue, Dec 10, 2013 at 01:36:10PM -0800, Seth Arnold wrote: > > Is building against the in-tree version the "best" default? > > Yes. If there's been any development of the parser that depends on > features of libapparmor that are ne

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-20 Thread Steve Beattie
On Tue, Dec 10, 2013 at 01:36:10PM -0800, Seth Arnold wrote: > Is building against the in-tree version the "best" default? Yes. If there's been any development of the parser that depends on features of libapparmor that are newer than your system's libapparmor, then your compilation will fail. As a

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-10 Thread John Johansen
On 12/06/2013 08:57 PM, Tyler Hicks wrote: > By default, statically link against the in-tree libapparmor. If the > in-tree libapparmor is not yet built, print a helpful error message. To > build against the system libapparmor, the SYSTEM_LIBAPPARMOR make > variable can be set on the command line li

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-10 Thread Tyler Hicks
On 2013-12-10 13:36:10, Seth Arnold wrote: > On Fri, Dec 06, 2013 at 08:57:57PM -0800, Tyler Hicks wrote: > > By default, statically link against the in-tree libapparmor. If the > > in-tree libapparmor is not yet built, print a helpful error message. To > > build against the system libapparmor, the

Re: [apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-10 Thread Seth Arnold
On Fri, Dec 06, 2013 at 08:57:57PM -0800, Tyler Hicks wrote: > By default, statically link against the in-tree libapparmor. If the > in-tree libapparmor is not yet built, print a helpful error message. To > build against the system libapparmor, the SYSTEM_LIBAPPARMOR make > variable can be set on t

[apparmor] [PATCH] parser: Add make variable to build against local or system libapparmor

2013-12-06 Thread Tyler Hicks
By default, statically link against the in-tree libapparmor. If the in-tree libapparmor is not yet built, print a helpful error message. To build against the system libapparmor, the SYSTEM_LIBAPPARMOR make variable can be set on the command line like so: $ make SYSTEM_LIBAPPARMOR=1 This patch a