-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 02/26/2013 04:02 PM, Seth Arnold wrote:
> On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
>
>> @@ -1091,13 +1098,13 @@ ssize_t aa_replace_profiles(void *udata, size_t
>> size, bool noreplace)
>
> Again, found while reviewing this
On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
> @@ -1091,13 +1098,13 @@ ssize_t aa_replace_profiles(void *udata, size_t size,
> bool noreplace)
Again, found while reviewing this patch, but not actually changed by
_this_ patch at all. (Sorry.) My comments are out here: vv
On 02/22/2013 05:08 PM, Seth Arnold wrote:
> On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
>
> The patch changed the 'Requires' comment here to mention rcu_read_lock
> must be held before calling __policy_find(). I've found code paths that
> appear to ignore this advice (again, us
On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
The patch changed the 'Requires' comment here to mention rcu_read_lock
must be held before calling __policy_find(). I've found code paths that
appear to ignore this advice (again, using HEAD).
> /**
> * __policy_find - find a policy
On 02/21/2013 10:16 AM, Seth Arnold wrote:
> Sorry this might be confusing, I had been looking at the top of your
> tree for my code inspections while reading through the details of the
> patch. So some of the references to profile->parent or __list_add_profile
> might have been added by _future_ p
Sorry this might be confusing, I had been looking at the top of your
tree for my code inspections while reading through the details of the
patch. So some of the references to profile->parent or __list_add_profile
might have been added by _future_ patches -- I was afraid I'd forget
the details if I
On 02/14/2013 12:31 AM, Seth Arnold wrote:
> On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
>> signed-offby: John Johansen
>> ---
>> security/apparmor/domain.c | 15 ++-
>> security/apparmor/include/apparmor.h |6 ++
>> security/apparmor/include/policy.h | 44 +
On 02/20/2013 08:01 PM, Seth Arnold wrote:
> On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
>> +/**
>> + * aa_get_profile_rcu - increment a refcount profile that can be replaced
>> + * @p: pointer to profile that can be replaced (NOT NULL)
>> + *
>> + * Returns: pointer to a refcoun
On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
> +/**
> + * aa_get_profile_rcu - increment a refcount profile that can be replaced
> + * @p: pointer to profile that can be replaced (NOT NULL)
> + *
> + * Returns: pointer to a refcounted profile.
> + * else NULL if no profile
> +
On Fri, Feb 08, 2013 at 01:00:55PM -0800, John Johansen wrote:
> signed-offby: John Johansen
> ---
> security/apparmor/domain.c | 15 ++-
> security/apparmor/include/apparmor.h |6 ++
> security/apparmor/include/policy.h | 44 +++-
> security/apparmor/policy.c |
signed-offby: John Johansen
---
security/apparmor/domain.c | 15 ++-
security/apparmor/include/apparmor.h |6 ++
security/apparmor/include/policy.h | 44 +++-
security/apparmor/policy.c | 195 ++
security/apparmor/policy_unpack.c
11 matches
Mail list logo
