Re: [apparmor] [PATCH V2] security/apparmor: fix matching on presence of extended attributes

2019-02-05 Thread Eric Chiang
Bumping this now that we're past the holidays :) On Fri, Dec 21, 2018 at 11:25 AM Eric Chiang wrote: > > Hey Seth, > > The proposed userland parser changes explicitly won't pass a > zero-sized array. However, modifying the parser to pass zero-sized > arrays causes kcalloc(0) to return ZERO_SIZE_P

Re: [apparmor] [PATCH V2] security/apparmor: fix matching on presence of extended attributes

2018-12-21 Thread Eric Chiang
Hey Seth, The proposed userland parser changes explicitly won't pass a zero-sized array. However, modifying the parser to pass zero-sized arrays causes kcalloc(0) to return ZERO_SIZE_PTR and the policy still works as if the array hadn't been passed at all. Note that other uses of unpack_array don

Re: [apparmor] [PATCH V2] security/apparmor: fix matching on presence of extended attributes

2018-12-20 Thread Seth Arnold
On Thu, Dec 20, 2018 at 01:28:38PM -0800, Eric Chiang wrote: > --- a/security/apparmor/policy_unpack.c > +++ b/security/apparmor/policy_unpack.c > @@ -535,6 +535,24 @@ static bool unpack_xattrs(struct aa_ext *e, struct > aa_profile *profile) > goto fail; > } > > +

[apparmor] [PATCH V2] security/apparmor: fix matching on presence of extended attributes

2018-12-20 Thread Eric Chiang
AppArmor recently added the ability for profiles to match extended attributes, with the intent of targeting "security.ima" and "security.evm" to differentiate between sign and unsigned files. The current implementation uses a path glob to match the extended attribute value. To require the presence