Re: [apparmor] [patch] Fix serialize_profile_from_old_profiles() to not crash on @{var} +=

2015-04-19 Thread Christian Boltz
Hello, Am Mittwoch, 15. April 2015 schrieb Steve Beattie: FYI, even with this patch and patch 33 applied, the tools will still crash when parsing a profile that extends an existing variable that's defined in an include file (like something under tunables/) like so: # Last Modified: Wed

Re: [apparmor] [patch] Fix serialize_profile_from_old_profiles() to not crash on @{var} +=

2015-04-15 Thread Steve Beattie
On Wed, Apr 08, 2015 at 11:06:23PM +0200, Christian Boltz wrote: serialize_profile_from_old_profiles() calls store_list_var() with an empty hasher. This fails for += because in this case store_list_var() expects a non-empty hasher with the variable already defined, and raises an exception

Re: [apparmor] [patch] Fix serialize_profile_from_old_profiles() to not crash on @{var} +=

2015-04-15 Thread Steve Beattie
On Wed, Apr 08, 2015 at 11:06:23PM +0200, Christian Boltz wrote: Hello, serialize_profile_from_old_profiles() calls store_list_var() with an empty hasher. This fails for += because in this case store_list_var() expects a non-empty hasher with the variable already defined, and raises an

[apparmor] [patch] Fix serialize_profile_from_old_profiles() to not crash on @{var} +=

2015-04-08 Thread Christian Boltz
Hello, serialize_profile_from_old_profiles() calls store_list_var() with an empty hasher. This fails for += because in this case store_list_var() expects a non-empty hasher with the variable already defined, and raises an exception because of the empty hasher. This patch sets correct = False if