Re: [apparmor] [patch] Fix writing network rules

2015-04-09 Thread Seth Arnold
On Thu, Apr 09, 2015 at 01:38:57PM +0200, Christian Boltz wrote: > > I wonder what happens if the 'audit' bit is > > triggered above; would this then emit rules like: > > > > auditnetwork bluetooth, > Fix writing network rules, part 2 > > write_net_rules() doesn't add a space after 'audit' in

Re: [apparmor] [patch] Fix writing network rules

2015-04-09 Thread Christian Boltz
Hello, Am Mittwoch, 8. April 2015 schrieb Seth Arnold: > I wonder what happens if the 'audit' bit is > triggered above; would this then emit rules like: > > auditnetwork bluetooth, > > ? Short answer: Yes, nice catch! Long answer: Fix writing network rules, part 2 write_net_rules() doesn'

Re: [apparmor] [patch] Fix writing network rules

2015-04-08 Thread Seth Arnold
On Wed, Apr 08, 2015 at 10:38:03PM +0200, Christian Boltz wrote: > Hello, > > sometimes fixing a bug is easy ;-) > > write_net_rules() creates invalid rules for network rules with one > parameter (for example "network bluetooth"). > Add a trailing comma to create valid rules. > > This is another

[apparmor] [patch] Fix writing network rules

2015-04-08 Thread Christian Boltz
Hello, sometimes fixing a bug is easy ;-) write_net_rules() creates invalid rules for network rules with one parameter (for example "network bluetooth"). Add a trailing comma to create valid rules. This is another bug uncovered by playing with the LibreOffice profile ("why does the profile have