Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-26 Thread Kshitij Gupta
Hello, On Sun, Apr 26, 2015 at 12:41 AM, Kshitij Gupta wrote: > Hello, > > On Wed, Apr 15, 2015 at 12:34 AM, Christian Boltz > wrote: > >> Hello, >> >> Am Montag, 13. April 2015 schrieb Steve Beattie: >> > On Tue, Apr 14, 2015 at 12:50:26AM +0200, Christian Boltz wrote: >> > > Am Montag, 13. Ap

Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-25 Thread Kshitij Gupta
Hello, On Wed, Apr 15, 2015 at 12:34 AM, Christian Boltz wrote: > Hello, > > Am Montag, 13. April 2015 schrieb Steve Beattie: > > On Tue, Apr 14, 2015 at 12:50:26AM +0200, Christian Boltz wrote: > > > Am Montag, 13. April 2015 schrieb Steve Beattie: > > > > On Sun, Apr 12, 2015 at 03:32:25AM +02

Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-23 Thread Christian Boltz
Hello, Am Dienstag, 14. April 2015 schrieb Christian Boltz: > Am Montag, 13. April 2015 schrieb Steve Beattie: > > I didn't initially (nothing in this patch description called out > > that it depended on that one. However, when I tried path 42 without > > patch 43 applied, the testing that I did

Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-14 Thread Christian Boltz
Hello, Am Montag, 13. April 2015 schrieb Steve Beattie: > On Tue, Apr 14, 2015 at 12:50:26AM +0200, Christian Boltz wrote: > > Am Montag, 13. April 2015 schrieb Steve Beattie: > > > On Sun, Apr 12, 2015 at 03:32:25AM +0200, Christian Boltz wrote: > > > > CleanProf.remove_duplicate_rules() didn't c

Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-13 Thread Steve Beattie
On Tue, Apr 14, 2015 at 12:50:26AM +0200, Christian Boltz wrote: > Hello, > > Am Montag, 13. April 2015 schrieb Steve Beattie: > > On Sun, Apr 12, 2015 at 03:32:25AM +0200, Christian Boltz wrote: > > > CleanProf.remove_duplicate_rules() didn't call > > > $profile['capability'].delete_duplicates(

Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-13 Thread Christian Boltz
Hello, Am Montag, 13. April 2015 schrieb Steve Beattie: > On Sun, Apr 12, 2015 at 03:32:25AM +0200, Christian Boltz wrote: > > CleanProf.remove_duplicate_rules() didn't call > > $profile['capability'].delete_duplicates() > > because aa-cleanprof sets same_file=True. > > > > Fix this by calling d

Re: [apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-13 Thread Steve Beattie
On Sun, Apr 12, 2015 at 03:32:25AM +0200, Christian Boltz wrote: > Hello, > > CleanProf.remove_duplicate_rules() didn't call > $profile['capability'].delete_duplicates() > because aa-cleanprof sets same_file=True. > > Fix this by calling delete_duplicates(None) so that it > only checks the prof

[apparmor] [patch] Make sure aa-cleanprof de-duplicates capability rules

2015-04-11 Thread Christian Boltz
Hello, CleanProf.remove_duplicate_rules() didn't call $profile['capability'].delete_duplicates() because aa-cleanprof sets same_file=True. Fix this by calling delete_duplicates(None) so that it only checks the profile against itsself. [ 43-cleanprof-do-in-profile-run.diff ] === modified fil