Re: [apparmor] [patch] Update aa-mergeprof to use the NetworkRule(set) class layout

2015-05-28 Thread Steve Beattie
On Mon, May 25, 2015 at 12:53:50AM +0200, Christian Boltz wrote: Hello, Am Sonntag, 17. Mai 2015 schrieb Christian Boltz: [ 08-mergeprof-network-rule.diff ] While thinking about patch 26, I noticed that aa-mergeprof isn't a good home for available_buttons(). Here's the updated patch that

Re: [apparmor] [patch] Update aa-mergeprof to use the NetworkRule(set) class layout

2015-05-24 Thread Christian Boltz
Hello, Am Sonntag, 17. Mai 2015 schrieb Christian Boltz: [ 08-mergeprof-network-rule.diff ] While thinking about patch 26, I noticed that aa-mergeprof isn't a good home for available_buttons(). Here's the updated patch that adds the function to aa.py instead. Besides moving the function (and

[apparmor] [patch] Update aa-mergeprof to use the NetworkRule(set) class layout

2015-05-17 Thread Christian Boltz
Hello, aa-mergeprof still used the old aa[profile][hat][allow]['netdomain'] which no longer gets populated. This resulted in not asking for merging any network rules. This patch changes ask_the_question() to the NetworkRule(set) layout. Besides that, - don't ask for network rules that are

Re: [apparmor] [patch] Update aa-mergeprof to use the NetworkRule(set) class layout

2015-05-17 Thread Christian Boltz
Hello, Am Sonntag, 17. Mai 2015 schrieb Christian Boltz: I tested all changes manually. ... and another test with a different profile resulted in a crash because other.aa[profile][hat]['network'] wasn't initialized :-( Here's the updated patch that - adds a check for that - moves around the