Re: [apparmor] [patch] tests: readdir - test both getdents() and getdents64() if available

2017-04-04 Thread Tyler Hicks
On 04/04/2017 03:24 PM, Steve Beattie wrote: > Hey Tyler, > > On Tue, Apr 04, 2017 at 02:03:53PM -0500, Tyler Hicks wrote: >> On 04/04/2017 01:14 PM, Steve Beattie wrote: >>> -int main(int argc, char *argv[]) >>> +#ifdef SYS_getdents >>> +int my_readdir(char *dirname) >> >> Nitpick... >> >> Please

Re: [apparmor] [patch] tests: readdir - test both getdents() and getdents64() if available

2017-04-04 Thread Steve Beattie
Hey Tyler, On Tue, Apr 04, 2017 at 02:03:53PM -0500, Tyler Hicks wrote: > On 04/04/2017 01:14 PM, Steve Beattie wrote: > > -int main(int argc, char *argv[]) > > +#ifdef SYS_getdents > > +int my_readdir(char *dirname) > > Nitpick... > > Please use my_getdents() and my_getdents64() since these are

Re: [apparmor] [patch] tests: readdir - test both getdents() and getdents64() if available

2017-04-04 Thread Tyler Hicks
On 04/04/2017 01:14 PM, Steve Beattie wrote: > Hey Colin, > > On Tue, Apr 04, 2017 at 03:16:29PM -, Colin Ian King wrote: >> Colin Ian King has proposed merging >> lp:~colin-king/apparmor/fix-arm64-test-builds into lp:apparmor. >> >> Requested reviews: >> AppArmor Developers (apparmor-dev)

[apparmor] [patch] tests: readdir - test both getdents() and getdents64() if available

2017-04-04 Thread Steve Beattie
Hey Colin, On Tue, Apr 04, 2017 at 03:16:29PM -, Colin Ian King wrote: > Colin Ian King has proposed merging > lp:~colin-king/apparmor/fix-arm64-test-builds into lp:apparmor. > > Requested reviews: > AppArmor Developers (apparmor-dev) > > For more details, see: > https://code.launchpad.ne