Re: [apparmor] [patch 03/26] fix failure paths around policy that can result in a crash

2014-04-15 Thread Seth Arnold
On Tue, Apr 15, 2014 at 10:22:10AM -0700, john.johan...@canonical.com wrote: Signed-off-by: John Johansen john.johan...@canonical.com Acked-by: Steve Beattie st...@nxnw.org There's a lot of extra code duplication here. I don't particularly like the way this thing turned out.. it's more

Re: [apparmor] [patch 03/26] fix failure paths around policy that can result in a crash

2014-04-15 Thread John Johansen
On 04/15/2014 04:48 PM, Seth Arnold wrote: On Tue, Apr 15, 2014 at 10:22:10AM -0700, john.johan...@canonical.com wrote: Signed-off-by: John Johansen john.johan...@canonical.com Acked-by: Steve Beattie st...@nxnw.org There's a lot of extra code duplication here. I don't particularly like

Re: [apparmor] [patch 03/26] fix failure paths around policy that can result in a crash

2014-04-15 Thread Seth Arnold
On Tue, Apr 15, 2014 at 05:11:10PM -0700, John Johansen wrote: we could do if (prof-policy.count 0) { prof-policy.dfa = aare_create_dfa(prof-policy.rules, prof-policy.size,