Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-15 Thread Christian Boltz
Hello, Am Dienstag, 15. Oktober 2013 schrieb Steve Beattie: > On Fri, Oct 11, 2013 at 10:08:51PM +0200, Christian Boltz wrote: > > We'll see if you still like this in some months... > > While I reserve the right to flake out^W^W change my mind, I help ;-) > maintain and improve other codebases

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-15 Thread Steve Beattie
On Tue, Oct 15, 2013 at 12:46:08PM -0700, Steve Beattie wrote: > That said, I was able to make the decorator function approach work. > Here's the updated patch: > > > Subject: parser - rewrite caching tests in python unittest Christian asked on IRC for a diff of the changes between the two versi

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-15 Thread Steve Beattie
On Fri, Oct 11, 2013 at 10:08:51PM +0200, Christian Boltz wrote: > We'll see if you still like this in some months... While I reserve the right to flake out^W^W change my mind, I help maintain and improve other codebases that don't get reviews before commits... and they sure could use it. > (and

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-11 Thread Christian Boltz
Hello, Am Donnerstag, 10. Oktober 2013 schrieb Steve Beattie: > On Fri, Oct 11, 2013 at 01:36:59AM +0200, Christian Boltz wrote: > > [sorry for the slightly broken quoting - KMail needs some > > improvement > > when quoting overlong lines ;-) ] > > No worries. I'm glad to see that the GSoC experi

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-10 Thread Steve Beattie
On Fri, Oct 11, 2013 at 01:36:59AM +0200, Christian Boltz wrote: > [sorry for the slightly broken quoting - KMail needs some improvement > when quoting overlong lines ;-) ] No worries. I'm glad to see that the GSoC experience has caused you to be less hesitant about reviewing python code. :) > A

Re: [apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-10 Thread Christian Boltz
Hello, [sorry for the slightly broken quoting - KMail needs some improvement when quoting overlong lines ;-) ] Am Donnerstag, 10. Oktober 2013 schrieb Steve Beattie: > --- /dev/null > +++ b/parser/tst/caching.py > +from optparse import OptionParser# deprecated, should move to > argparse eve

[apparmor] [patch 05/13] parser - rewrite caching tests in python unittest

2013-10-10 Thread Steve Beattie
This patch rewrites the caching test in python, using python's unittest framework. It has been used with python 2.7 and python 3.3; python2.6 may have issues. It covers the tests in the existing caching.sh test script (with the exception of the test that checks for when the parser in $PATH is newer