Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-03 Thread Steve Beattie
On Wed, Dec 03, 2014 at 07:19:11PM +0100, Christian Boltz wrote: > The remaining question is if we want to split the commit to know who > broke which part *g* or if we just commit the merged patch with two > authors mentioned. By passing multiple --author flags to bzr commit, we can list both of

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-03 Thread Steve Beattie
On Mon, Dec 01, 2014 at 11:37:14AM -0800, Seth Arnold wrote: > On Sun, Nov 30, 2014 at 12:45:49AM +0100, Christian Boltz wrote: > > > Second is that I think these changes are large enough to not be > > > acceptable for 2.9.1, and that we should branch off 2.9.x before > > > committing this patch se

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-03 Thread Steve Beattie
On Mon, Dec 01, 2014 at 07:51:16PM +0100, Christian Boltz wrote: > Am Sonntag, 30. November 2014 schrieb Christian Boltz: > > Let me warn you that your __init__() also has a regression when > > compared with my set_* functions - imagine someone calls it with a > > raw_rule that completely differs f

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-03 Thread Christian Boltz
Hello, Am Mittwoch, 3. Dezember 2014 schrieb Steve Beattie: > On Sun, Nov 30, 2014 at 12:45:49AM +0100, Christian Boltz wrote: > I agree with that; however, I think the difference between the two > situations (raw_rule not matching the passed cap_list versus calling > set_param() twice) is that y

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-03 Thread Steve Beattie
On Sun, Nov 30, 2014 at 12:45:49AM +0100, Christian Boltz wrote: > Let me warn you that your __init__() also has a regression when compared > with my set_* functions - imagine someone calls it with a raw_rule that > completely differs from the other parameters, like > > cap_rule = Capability

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-01 Thread Seth Arnold
On Sun, Nov 30, 2014 at 12:45:49AM +0100, Christian Boltz wrote: > > Second is that I think these changes are large enough to not be > > acceptable for 2.9.1, and that we should branch off 2.9.x before > > committing this patch set. > You are right that the changes are quite big for a maintenance

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-12-01 Thread Christian Boltz
Hallo Leute, Am Sonntag, 30. November 2014 schrieb Christian Boltz: > Let me warn you that your __init__() also has a regression when > compared with my set_* functions - imagine someone calls it with a > raw_rule that completely differs from the other parameters, like > > cap_rule = Capabili

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-29 Thread Christian Boltz
Hello, Am Samstag, 29. November 2014 schrieb Steve Beattie: > First off, let me say thanks for driving forward on this and not > getting put off by my feedback. I know I sometimes send out evil feedback, so I'm not surprised you take your chance for a revenge ;-) And I'm also not surprised that

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-29 Thread Steve Beattie
Hi Christian, First off, let me say thanks for driving forward on this and not getting put off by my feedback. Second is that I think these changes are large enough to not be acceptable for 2.9.1, and that we should branch off 2.9.x before committing this patch set. > The updated patch (v4) is a

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-27 Thread Christian Boltz
Hello, Am Dienstag, 25. November 2014 schrieb Steve Beattie: > On Sun, Nov 23, 2014 at 01:01:31AM +0100, Christian Boltz wrote: > > Am Freitag, 21. November 2014 schrieb Steve Beattie: > > > On Sat, Nov 15, 2014 at 11:46:41PM +0100, Christian Boltz wrote: > So while testing with the v3 versions o

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-25 Thread Steve Beattie
On Sun, Nov 23, 2014 at 01:01:31AM +0100, Christian Boltz wrote: > Am Freitag, 21. November 2014 schrieb Steve Beattie: > > On Sat, Nov 15, 2014 at 11:46:41PM +0100, Christian Boltz wrote: > > > I also had to add several > > > +if write_prof_data[name].get(segs, False): > > > +

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-22 Thread Christian Boltz
Hello, Am Freitag, 21. November 2014 schrieb Steve Beattie: > On Sat, Nov 15, 2014 at 11:46:41PM +0100, Christian Boltz wrote: > > this patch changes aa.py and cleanprof.py to use the new capabiliy > > rule class. > > > > The most important details in the change are: > > - the capability rules ar

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-21 Thread Christian Boltz
Hello, Am Samstag, 15. November 2014 schrieb Christian Boltz: > this patch changes aa.py and cleanprof.py to use the new capabiliy > rule class. The updated patch (v2) is attached. Only change: The patch got updated to match the changed class and function names of the rule class. This also mea

Re: [apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-21 Thread Steve Beattie
On Sat, Nov 15, 2014 at 11:46:41PM +0100, Christian Boltz wrote: > Hello, > > this patch changes aa.py and cleanprof.py to use the new capabiliy rule > class. > > The most important details in the change are: > - the capability rules are stored in > aa[profile][hat]['capability'] instead of >

[apparmor] [patch 3/3] use capability rule class in aa.py and cleanprof.py

2014-11-15 Thread Christian Boltz
Hello, this patch changes aa.py and cleanprof.py to use the new capabiliy rule class. The most important details in the change are: - the capability rules are stored in aa[profile][hat]['capability'] instead of aa[profile][hat]['allow']['capability'] and aa[profile][hat]['deny']['capabil