Re: [apparmor] [patch 4/9] profiles - fix apparmor_api abstractions

2013-01-02 Thread John Johansen
On 01/02/2013 02:52 PM, Steve Beattie wrote: > On Tue, Dec 18, 2012 at 02:39:55PM -0800, John Johansen wrote: >> On 12/18/2012 06:17 AM, Steve Beattie wrote: >>> The apparmor_api abstractions make the mistake of including tunables >>> directly, which is a no-no since the variable definitions in tun

Re: [apparmor] [patch 4/9] profiles - fix apparmor_api abstractions

2013-01-02 Thread Steve Beattie
On Tue, Dec 18, 2012 at 02:39:55PM -0800, John Johansen wrote: > On 12/18/2012 06:17 AM, Steve Beattie wrote: > > The apparmor_api abstractions make the mistake of including tunables > > directly, which is a no-no since the variable definitions in tunables > > need to occur in the preamble of a pro

Re: [apparmor] [patch 4/9] profiles - fix apparmor_api abstractions

2012-12-18 Thread John Johansen
On 12/18/2012 06:17 AM, Steve Beattie wrote: > The apparmor_api abstractions make the mistake of including tunables > directly, which is a no-no since the variable definitions in tunables > need to occur in the preamble of a profile, not embedded within it. > This patch removes those includes, and

Re: [apparmor] [patch 4/9] profiles - fix apparmor_api abstractions

2012-12-18 Thread Seth Arnold
On Tue, Dec 18, 2012 at 06:17:59AM -0800, Steve Beattie wrote: > The apparmor_api abstractions make the mistake of including tunables > directly, which is a no-no since the variable definitions in tunables > need to occur in the preamble of a profile, not embedded within it. > This patch removes th

[apparmor] [patch 4/9] profiles - fix apparmor_api abstractions

2012-12-18 Thread Steve Beattie
The apparmor_api abstractions make the mistake of including tunables directly, which is a no-no since the variable definitions in tunables need to occur in the preamble of a profile, not embedded within it. This patch removes those includes, and replaces them documentation of tunables are necessary