Re: [apparmor] GSoC review r30

2013-08-02 Thread John Johansen
On 08/01/2013 02:59 PM, Christian Boltz wrote: Hello, the review for r30 is attached - it had lots of new code (and interesting[tm] regexes) - therefore I have several notes about it ;-) @John: The review contains some questions for you - can you please answer them? === modified

Re: [apparmor] GSoC review r30

2013-08-02 Thread Christian Boltz
Hello, John Johansen wrote: On 08/01/2013 02:59 PM, Christian Boltz wrote: ### a check if the hat already exists might be useful to avoid duplicate hat names (which might get merged on write, but I doubt that's intended behaviour) ### interestingly, the parser does _not_ complain about

[apparmor] GSoC review r30

2013-08-01 Thread Christian Boltz
Hello, the review for r30 is attached - it had lots of new code (and interesting[tm] regexes) - therefore I have several notes about it ;-) @John: The review contains some questions for you - can you please answer them? Regards, Christian Boltz -- My calendar shows May 12th to be a Friday,