Hello,
the (quite small) reviews for r70 and r72 are attached. The r70 review
also contains two bugs I noticed.
For r71, I have no reason to complain ;-)
Regards,
Christian Boltz
--
> Das Autofahrersyndrom: Prüft Euren Ton.
*anschlag*
*bonk*
Stimmt, der Ton ist nicht sonderlich...
[> Peter Lipp und David Haller in suse-linux]
------------------------------------------------------------
revno: 70
committer: Kshitij Gupta <kgupta8...@gmail.com
branch nick: apparmor-profile-tools
timestamp: Sun 2013-09-22 15:01:34 +0530
message:
So that closes the first proper version of aa-cleanprof with testcases added,
fixed profile writer to work on multiple profiles at once, please use the
view clean changes option in logprof and genprof, the comment preserver
version needs tweaking that version wont be written anyways. Plus a few other
changes
=== modified file 'Tools/aa-cleanprof'
--- Tools/aa-cleanprof 2013-09-19 05:02:19 +0000
+++ Tools/aa-cleanprof 2013-09-22 09:31:34 +0000
@@ -7,6 +7,7 @@
parser = argparse.ArgumentParser(description='Cleanup the profiles for the
given programs')
parser.add_argument('-d', '--dir', type=str, help='path to profiles')
parser.add_argument('program', type=str, nargs='+', help='name of program')
+parser.add_argument('-s', '--silent', action='store_true', help='Silently
over-write with cleanprofile')
# "...with clean profile"
=== modified file 'Tools/manpages/aa-cleanprof.pod'
--- Tools/manpages/aa-cleanprof.pod 2013-09-20 19:38:34 +0000
+++ Tools/manpages/aa-cleanprof.pod 2013-09-22 09:31:34 +0000
+B<-s --silent>
+
+ Silently over-writes the profile without user prompt.
# overwrites
# cleanprof test results (cleaning up the nptd profile)
# network inet stream was removed, but network inet6 stream was not (both
covered by abstractions/nameservice, so both should have been removed)
# besides that, the cleaned profile looks good
# (well, it shouldn't contain the "allow" keyword in all lines, but that's a
known issue in the write method)
# from testing logprof:
# I used -d ./profiles, but when saving a profile (with the "Save Selec(t)ed
Profile" option), it was written to /etc/apparmor.d/
vim:ft=diff
------------------------------------------------------------
revno: 72
committer: Kshitij Gupta <kgupta8...@gmail.com
branch nick: apparmor-profile-tools
timestamp: Sun 2013-09-22 15:25:20 +0530
message:
Added help messages to translate strings and a few other minor fixes
=== modified file 'Tools/aa-cleanprof'
--- Tools/aa-cleanprof 2013-09-22 09:31:34 +0000
+++ Tools/aa-cleanprof 2013-09-22 09:55:20 +0000
-parser.add_argument('-s', '--silent', action='store_true', help='Silently
over-write with cleanprofile')
+parser.add_argument('-s', '--silent', action='store_true', help=_('Silently
over-write with a clean profile'))
# "overwrite"
=== modified file 'Tools/aa-mergeprof'
--- Tools/aa-mergeprof 2013-09-19 05:02:19 +0000
+++ Tools/aa-mergeprof 2013-09-22 09:55:20 +0000
##parser.add_argument('profiles', type=str, nargs=3, help='MINE BASE OTHER')
-parser.add_argument('-auto', action='store_true', help='Automatically merge
profiles, exits incase of *x conflicts')
+parser.add_argument('-auto', action='store_true', help=_('Automatically merge
profiles, exits incase of *x conflicts'))
# should it be '--auto'?
vim:ft=diff
--
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/apparmor
