Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

On Thu, Apr 17, 2014 at 10:48:07AM -0700, Steve Beattie wrote: > parser: find SIZE_MAX on older versions of glibc and g++ > > Another issue with commit 2456 is that with older versions of glibc and > g++, a definition for SIZE_MAX was not being found; e.g. on Ubuntu 12.04 > LTS and 12.10, the pars

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

On 04/17/2014 10:48 AM, Steve Beattie wrote: > parser: find SIZE_MAX on older versions of glibc and g++ > > Another issue with commit 2456 is that with older versions of glibc and > g++, a definition for SIZE_MAX was not being found; e.g. on Ubuntu 12.04 > LTS and 12.10, the parser fails to compil

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

parser: find SIZE_MAX on older versions of glibc and g++ Another issue with commit 2456 is that with older versions of glibc and g++, a definition for SIZE_MAX was not being found; e.g. on Ubuntu 12.04 LTS and 12.10, the parser fails to compile with the following error: g++ -g -O2 -pipe -Wall -

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

On Wed, Apr 16, 2014 at 11:08:39PM -0700, Steve Beattie wrote: > Unfortunately, this patch breaks builds on i386, with the following > failure: > > g++ -g -O2 -pipe -Wall -Wsign-compare -Wmissing-field-initializers > -Wformat-security -Wunused-parameter -std=gnu++0x -D_GNU_SOURCE > -DPACKAGE=\

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

On 04/16/2014 11:08 PM, Steve Beattie wrote: > Unfortunately, this patch breaks builds on i386, with the following > failure: > > g++ -g -O2 -pipe -Wall -Wsign-compare -Wmissing-field-initializers > -Wformat-security -Wunused-parameter -std=gnu++0x -D_GNU_SOURCE > -DPACKAGE=\"apparmor-parser\"

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

Unfortunately, this patch breaks builds on i386, with the following failure: g++ -g -O2 -pipe -Wall -Wsign-compare -Wmissing-field-initializers -Wformat-security -Wunused-parameter -std=gnu++0x -D_GNU_SOURCE -DPACKAGE=\"apparmor-parser\" -DLOCALEDIR=\"/usr/share/locale\" -DSUBDOMAIN_CONFDIR=\

Re: [apparmor] Rev 2456: Unify escape sequence processing into a set of library fns.

Hi John, I hadn't finished my review of this patch before it got committed, but with the move of the unit tests into parser/lib.c, can you back out the following bit as it's no longer necessary? > === modified file 'parser/libapparmor_re/Makefile' > --- parser/libapparmor_re/Makefile2013-12-0