Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-18 Thread Morten Linderud via arch-dev-public
On Wed, May 13, 2020 at 10:16:43PM +0200, Morten Linderud wrote: > If there are no objections, I'll probably merge the guidelines this weekend > section-by-section to make the wiki admins happy. The new package should land > sometime nextweek. It's been done. `go-pie` is no more. Please look over

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-15 Thread Christian Rebischke via arch-dev-public
On Wed, May 13, 2020 at 10:16:38PM +0200, Public mailing list for Arch Linux development wrote: > Yo! > > After another few lazy weeks I have finished up the new Go packaging > guidelines. > > https://wiki.archlinux.org/index.php/User:Foxboron/Go_packaging_guidelines#Flags_and_build_options >

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-14 Thread Levente Polyak via arch-dev-public
On 5/14/20 9:46 AM, Morten Linderud wrote: > On Thu, May 14, 2020 at 09:39:58AM +0200, Levente Polyak via arch-dev-public > wrote: >>> At the end of the month I'll make a todo with the remaining packages >>> depending >>> on `go-pie`. >>> >>> The complete future Go PKGBUILD is attached to this em

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-14 Thread Morten Linderud via arch-dev-public
On Thu, May 14, 2020 at 09:39:58AM +0200, Levente Polyak via arch-dev-public wrote: > > At the end of the month I'll make a todo with the remaining packages > > depending > > on `go-pie`. > > > > The complete future Go PKGBUILD is attached to this email below. > > > PS: shouldn't we look into G

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-14 Thread Levente Polyak via arch-dev-public
On 5/13/20 10:16 PM, Morten Linderud via arch-dev-public wrote: > > If there are no objections, I'll probably merge the guidelines this weekend > section-by-section to make the wiki admins happy. The new package should land > sometime nextweek. > Awesome, thanks a lot this is a great step to imp

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-13 Thread Morten Linderud via arch-dev-public
On Wed, May 13, 2020 at 04:35:11PM -0400, Eli Schwartz via arch-dev-public wrote: > On 5/13/20 4:16 PM, Morten Linderud via arch-dev-public wrote: > > The complete future Go PKGBUILD is attached to this email below. > > > ``` > replaces=(go-pie) > provides=(go-pie) > ``` > > Should this provide

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-13 Thread Eli Schwartz via arch-dev-public
On 5/13/20 4:16 PM, Morten Linderud via arch-dev-public wrote: > The complete future Go PKGBUILD is attached to this email below. ``` replaces=(go-pie) provides=(go-pie) ``` Should this provide it too? Anything that explicitly expected go-pie cannot assume the new package is a drop-in replacemen

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-13 Thread Morten Linderud via arch-dev-public
Yo! After another few lazy weeks I have finished up the new Go packaging guidelines. https://wiki.archlinux.org/index.php/User:Foxboron/Go_packaging_guidelines#Flags_and_build_options The changes that has been done since last time is some structing of the page, added a list explaining all the fl

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-06 Thread Morten Linderud via arch-dev-public
On Thu, Apr 30, 2020 at 04:58:01PM -0400, Eli Schwartz via arch-dev-public wrote: > Why does it matter to makepkg how the go compiler downloads source code, > or using which options? Any download that is done outside the source=() > array is violating the PKGBUILD contract, and is not cached in $S

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-05-06 Thread Morten Linderud via arch-dev-public
On Thu, Apr 30, 2020 at 12:56:30AM -0700, Anatol Pomozov via arch-dev-public wrote: > And if we plan to encourage adding the cache warmup to all golang > PKGBUILD (that's gonna be thousands of packages) then this extra > complexity need be justified. Anyone who wants to follow our advise > needs t

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-04-30 Thread Eli Schwartz via arch-dev-public
On 4/30/20 3:56 AM, Anatol Pomozov via arch-dev-public wrote: > Thank you for coming up with this document. > > Go is a fantastic language and I would love to see more people using > it. Having things documented will help our users to get more > comfortable with the golang packaging. This RFC is

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-04-30 Thread Anatol Pomozov via arch-dev-public
Hi Morten On Sun, Apr 19, 2020 at 3:32 PM Morten Linderud via arch-dev-public wrote: > > Yo! > > After being lazy for a few weeks, I got around to writing the new guidelines > for > Go packages. Currently it's a draft and I'd love if people read through it and > ack/nacked > > https://wiki.archl

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-04-25 Thread Christian Rebischke via arch-dev-public
On Mon, Apr 20, 2020 at 12:32:18AM +0200, Public mailing list for Arch Linux development wrote: > I have also removed `-mod=vendor` from the default listing in `prepare()` as > Anatol wasn't fond of the idea. I'm still unsure if we really want this as we > would be willynilly downloading sources i

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-04-19 Thread Bartłomiej Piotrowski via arch-dev-public
On 20/04/2020 00.32, Morten Linderud via arch-dev-public wrote: > I have also removed `-mod=vendor` from the default listing in `prepare()` as > Anatol wasn't fond of the idea. I'm still unsure if we really want this as we > would be willynilly downloading sources in `build()` and `check()` during

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-04-19 Thread Morten Linderud via arch-dev-public
On Mon, Apr 20, 2020 at 09:05:27AM +0300, Christoph Gysin wrote: > On Mon, Apr 20, 2020 at 1:32 AM Morten Linderud via arch-dev-public < > arch-dev-public@archlinux.org> wrote: > > > https://wiki.archlinux.org/index.php/User:Foxboron/Go_packaging_guidelines > > > > In the fist example, you set bo

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-04-19 Thread Morten Linderud via arch-dev-public
Yo! After being lazy for a few weeks, I got around to writing the new guidelines for Go packages. Currently it's a draft and I'd love if people read through it and ack/nacked https://wiki.archlinux.org/index.php/User:Foxboron/Go_packaging_guidelines The current changes is dropping anything pre-1

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Eli Schwartz via arch-dev-public
On 3/15/20 4:40 PM, Morten Linderud via arch-dev-public wrote: > I'm aware that go {list,build,test} fetches dependencies on the fly. > > And let me reiterate again; *This shouldn't happen*. > > We should be capable of performing complete software builds without internet > connection. If we can'

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Morten Linderud via arch-dev-public
On Sun, Mar 15, 2020 at 01:09:19PM -0700, Anatol Pomozov via arch-dev-public wrote: > Hello > > On Sun, Mar 15, 2020 at 12:24 PM Morten Linderud via arch-dev-public > wrote: > > > > On Sun, Mar 15, 2020 at 12:09:07PM -0700, Anatol Pomozov via > > arch-dev-public wrote: > > > > Notice that `-mod

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Anatol Pomozov via arch-dev-public
Hello On Sun, Mar 15, 2020 at 12:24 PM Morten Linderud via arch-dev-public wrote: > > On Sun, Mar 15, 2020 at 12:09:07PM -0700, Anatol Pomozov via arch-dev-public > wrote: > > > Notice that `-mod=vendor` is also added to `GOFLAGS`. > > > > Most of the Go projects do not vendorize their dependenc

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Anatol Pomozov via arch-dev-public
Hi On Sun, Mar 15, 2020 at 12:16 PM Christian Rebischke via arch-dev-public wrote: > > On Sun, Mar 15, 2020 at 12:09:07PM -0700, Public mailing list for Arch Linux > development wrote: > > Hello Morten > > > > On Sun, Mar 15, 2020 at 5:38 AM Morten Linderud via arch-dev-public > > wrote: > > >

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Morten Linderud via arch-dev-public
On Sun, Mar 15, 2020 at 12:09:07PM -0700, Anatol Pomozov via arch-dev-public wrote: > > Notice that `-mod=vendor` is also added to `GOFLAGS`. > > Most of the Go projects do not vendorize their dependencies to avoid > polluting the source tree. > > And there is no point to force vendorizing in th

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Christian Rebischke via arch-dev-public
On Sun, Mar 15, 2020 at 12:09:07PM -0700, Public mailing list for Arch Linux development wrote: > Hello Morten > > On Sun, Mar 15, 2020 at 5:38 AM Morten Linderud via arch-dev-public > wrote: > > > > > > # Introduction > > > > To enable PIE compilation, we have relied on a patched version of the

Re: [arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Anatol Pomozov via arch-dev-public
Hello Morten On Sun, Mar 15, 2020 at 5:38 AM Morten Linderud via arch-dev-public wrote: > > > # Introduction > > To enable PIE compilation, we have relied on a patched version of the go > compiler which has been distributed as `go-pie` since around 2017. However, > full > RELRO support for go bi

[arch-dev-public] RFC: go-pie removal in favour of GOFLAGS

2020-03-15 Thread Morten Linderud via arch-dev-public
# Introduction To enable PIE compilation, we have relied on a patched version of the go compiler which has been distributed as `go-pie` since around 2017. However, full RELRO support for go binaries has been a bit back and forth the past years. With some thing working, and other things don't. Wi