Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Bernardo Barros
If I may: I think if they (devs) work with that particular program, they should know better if a -O3 optimization is more adequate or not then a -O2 or whatever, more then the packager -- that is not so deeply involved with the project anyway.

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Ray Rashif
On 5 August 2011 16:54, Jan de Groot wrote: > On Fri, 2011-08-05 at 15:23 +0800, Ray Rashif wrote: > >> For eg. some developers like to enforce -O3, so they should first get >> the system CFLAGS and override it's -O*, if any. >> >> But in general, I agree. We shouldn't enforce anything either unle

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Lukas Fleischer
On Fri, Aug 05, 2011 at 10:54:41AM +0200, Jan de Groot wrote: > On Fri, 2011-08-05 at 15:23 +0800, Ray Rashif wrote: > > > For eg. some developers like to enforce -O3, so they should first get > > the system CFLAGS and override it's -O*, if any. > > > > But in general, I agree. We shouldn't enfor

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Lukas Fleischer
On Fri, Aug 05, 2011 at 03:23:44PM +0800, Ray Rashif wrote: > On 5 August 2011 07:35, Lukas Fleischer wrote: > > My own opinion is that we shouldn't patch anything here. While using the > > same optimization flags for all packages might result in some kind of > > consistency, one of our main guide

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Lukas Fleischer
On Fri, Aug 05, 2011 at 03:02:17PM +1000, Allan McRae wrote: > On 05/08/11 09:35, Lukas Fleischer wrote: > >In the course of a discussion with the xwax [1] developer, I was asked > >the question why we would override CFLAGS (optimization levels, in > >particular) if upstream already provides them.

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Jan de Groot
On Fri, 2011-08-05 at 15:23 +0800, Ray Rashif wrote: > For eg. some developers like to enforce -O3, so they should first get > the system CFLAGS and override it's -O*, if any. > > But in general, I agree. We shouldn't enforce anything either unless > we're trying to fix something. The ardour PKGB

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-05 Thread Ray Rashif
On 5 August 2011 07:35, Lukas Fleischer wrote: > My own opinion is that we shouldn't patch anything here. While using the > same optimization flags for all packages might result in some kind of > consistency, one of our main guidelines - not to do any unnecessary > modifications - is kind of viola

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-04 Thread Allan McRae
On 05/08/11 09:35, Lukas Fleischer wrote: In the course of a discussion with the xwax [1] developer, I was asked the question why we would override CFLAGS (optimization levels, in particular) if upstream already provides them. Given that there are in fact loads of packages in our repositories tha

Re: [arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-04 Thread Kyle
It seems to me that CFLAGS should only be overridden on a per system basis in the makepkg configuration. Of course they could also be set in a local PKGBUILD or in AUR, but packages in the repos should stay as close to upstream as possible. It should also be noted that suggesting working optimiz

[arch-general] Enforcing CFLAGS in PKGBUILDs

2011-08-04 Thread Lukas Fleischer
In the course of a discussion with the xwax [1] developer, I was asked the question why we would override CFLAGS (optimization levels, in particular) if upstream already provides them. Given that there are in fact loads of packages in our repositories that seem to follow this practice (`grep -- '-O