Re: [arch-general] Removing gitolite package doesn't remove gitolite user

2017-04-01 Thread Eli Schwartz via arch-general
On 03/31/2017 10:12 PM, Ricardo Band wrote: > On Fri, 2017-03-31 at 20:37 -0500, Doug Newgard wrote: >> >> Short version here, you deleted the user's home dir manually and left >> the user. >> That's not a packaging problem. > > Yep. But shouldn't the home dir be recreated when I reinstall the > p

Re: [arch-general] Removing gitolite package doesn't remove gitolite user

2017-04-01 Thread Óscar García Amor
The main problem is that the _useradd_ is launched with -m parameter that creates the home directory to gitolite user. If user already exists then the home directory is not recreated. IMHO is better don't use -m modifier and do something like this: if [[ ! -d /var/lib/gitolite ]] ; then mkdir

Re: [arch-general] Removing gitolite package doesn't remove gitolite user

2017-03-31 Thread Ricardo Band
On Fri, 2017-03-31 at 20:37 -0500, Doug Newgard wrote: > > Short version here, you deleted the user's home dir manually and left > the user. > That's not a packaging problem. Yep. But shouldn't the home dir be recreated when I reinstall the package? It seems that the package only executes a usera

Re: [arch-general] Removing gitolite package doesn't remove gitolite user

2017-03-31 Thread Doug Newgard
On Sat, 01 Apr 2017 03:01:04 +0200 Ricardo Band wrote: > I think this is a bug. When gitolite is uninstalled it should also > remove the gitolite user. No, it shouldn't. A deleted user presents a security issue, since the package has no way of knowing if there's any files/dirs left owned by that

[arch-general] Removing gitolite package doesn't remove gitolite user

2017-03-31 Thread Ricardo Band
Ahoi, I was removing gitolite because I fucked my setup up. When I reinstalled it to start from scratch, I ran into a problem. The /var/lib/gitolite folder wasn't created when I reinstalled the package. I found out that the gitolite user also still existed. I removed it and reinstalled gitolite.