Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Kurt J. Bosch
2010-09-20 22:51, Dave Reisner: Your echo is redundant. Just quote the expansion and assign it. NAK. Try this: MODULES=( '!foo' '!bar' ) modules="${modul...@]/#\!*}" [[ $modules ]]&& echo "'$modules' is not a null string" ' ' is not a null string modules="${modul...@]/#\!*}" I think we're

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Dave Reisner
> > > >Your echo is redundant. Just quote the expansion and assign it. > > > NAK. Try this: > MODULES=( '!foo' '!bar' ) > modules="${modul...@]/#\!*}" > [[ $modules ]] && echo "'$modules' is not a null string" > ' ' is not a null string > > >modules="${modul...@]/#\!*}" > > > >I think we're a looo

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Kurt J. Bosch
2010-09-20 22:22, Kurt J. Bosch: 2010-09-20 17:56, Dave Reisner: On Mon, Sep 20, 2010 at 05:39:25PM +0200, Kurt J. Bosch wrote: 2010-09-20 04:10, Dave Reisner: On Mon, Sep 20, 2010 at 11:57:06AM +1000, Allan McRae wrote: On 20/09/10 11:54, Dave Reisner wrote: Use modprobe -a and a bash PE to

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Tavian Barnes
On 20 September 2010 16:22, Kurt J. Bosch wrote: > 2010-09-20 17:56, Dave Reisner: >> >> On Mon, Sep 20, 2010 at 05:39:25PM +0200, Kurt J. Bosch wrote: >>> >>> 2010-09-20 04:10, Dave Reisner: On Mon, Sep 20, 2010 at 11:57:06AM +1000, Allan McRae wrote: > > On 20/09/10 11:54, Dave

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Kurt J. Bosch
2010-09-20 17:56, Dave Reisner: On Mon, Sep 20, 2010 at 05:39:25PM +0200, Kurt J. Bosch wrote: 2010-09-20 04:10, Dave Reisner: On Mon, Sep 20, 2010 at 11:57:06AM +1000, Allan McRae wrote: On 20/09/10 11:54, Dave Reisner wrote: Use modprobe -a and a bash PE to filter the MODULES array. Signed

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Dave Reisner
On Mon, Sep 20, 2010 at 05:39:25PM +0200, Kurt J. Bosch wrote: > 2010-09-20 04:10, Dave Reisner: > >On Mon, Sep 20, 2010 at 11:57:06AM +1000, Allan McRae wrote: > >>On 20/09/10 11:54, Dave Reisner wrote: > >>>Use modprobe -a and a bash PE to filter the MODULES array. > >>> > >>>Signed-off-by: Dave

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-20 Thread Kurt J. Bosch
2010-09-20 04:10, Dave Reisner: On Mon, Sep 20, 2010 at 11:57:06AM +1000, Allan McRae wrote: On 20/09/10 11:54, Dave Reisner wrote: Use modprobe -a and a bash PE to filter the MODULES array. Signed-off-by: Dave Reisner --- rc.sysinit | 12 1 files changed, 4 insertions(+), 8

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-19 Thread Dave Reisner
On Mon, Sep 20, 2010 at 11:57:06AM +1000, Allan McRae wrote: > On 20/09/10 11:54, Dave Reisner wrote: > >Use modprobe -a and a bash PE to filter the MODULES array. > > > >Signed-off-by: Dave Reisner > >--- > > rc.sysinit | 12 > > 1 files changed, 4 insertions(+), 8 deletions(-) > >

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-19 Thread Allan McRae
On 20/09/10 11:54, Dave Reisner wrote: Use modprobe -a and a bash PE to filter the MODULES array. Signed-off-by: Dave Reisner --- rc.sysinit | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/rc.sysinit b/rc.sysinit index 09d5e97..4b6e1e7 100755 --- a/rc.sysin

Re: [arch-general] [PATCH] rc.sysinit: only call modprobe once

2010-09-19 Thread Dave Reisner
On Sun, Sep 19, 2010 at 08:47:03PM -0400, Dave Reisner wrote: > Use modprobe -a and a bash PE to filter the MODULES array. > > Signed-off-by: Dave Reisner > --- > rc.sysinit |6 +- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/rc.sysinit b/rc.sysinit > index 09d5e9