Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Naduni Pamudika
On Thu, Apr 30, 2020 at 9:54 PM Malintha Amarasinghe wrote: > +1 to make the commands consistent and create an issue to track. > We should evaluate a few other CLI tools too and see what is the best > approach (deciding a command format and deprecating commands). A couple of > "newly added

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Malintha Amarasinghe
+1 to make the commands consistent and create an issue to track. We should evaluate a few other CLI tools too and see what is the best approach (deciding a command format and deprecating commands). A couple of "newly added commands" Wasura mentioned above are already in the pipeline for apictl

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Harsha Kumara
+1 for the change in the next release. @wasura @malintha shall we create a issue and track it? On Fri, May 1, 2020 at 12:06 AM Bhathiya Jayasekara wrote: > Yes, we can keep both formats for some time, and mention the old format is > deprecated. It won't affect any existing users that way. We

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Bhathiya Jayasekara
Yes, we can keep both formats for some time, and mention the old format is deprecated. It won't affect any existing users that way. We just need to decide when we can do this. Thanks, Bhathiya On Thu, Apr 30, 2020 at 6:57 PM Harsha Kumara wrote: > > > On Thu, Apr 30, 2020 at 11:18 PM Uvindra

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Harsha Kumara
On Thu, Apr 30, 2020 at 11:18 PM Uvindra Dias Jayasinha wrote: > Ideally it would be great if we could make the commands more consistent > but we need to take care about changing existing ones because we can end up > breaking customers existing CI/CD flows. > > The commands are now a binding

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Uvindra Dias Jayasinha
Ideally it would be great if we could make the commands more consistent but we need to take care about changing existing ones because we can end up breaking customers existing CI/CD flows. The commands are now a binding API. If we are changing them in the future we need to first deprecate the

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Harsha Kumara
On Thu, Apr 30, 2020 at 10:02 PM Wasura Wattearachchi wrote: > Hi all, > > There are two (2) types of command signatures in API Controller such as apictl > [verb] [noun] [flags] and apictl [command] [flags]. Below are the > commands belonging to those two (2) categories. > > apictl [verb] [noun]

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Wasura Wattearachchi
Hi all, There are two (2) types of command signatures in API Controller such as apictl [verb] [noun] [flags] and apictl [command] [flags]. Below are the commands belonging to those two (2) categories. apictl [verb] [noun] [flags] apictl [command] [flags] Existing commands: - apictl

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Harsha Kumara
On Thu, Apr 30, 2020 at 4:46 PM Bhathiya Jayasekara wrote: > It would have been ideal if we had the commands in this format. > > *apictl * > eg. > apictl list apis > apictl list api-products > apictl create api > apictl create api-product > We don't have create operations right. It's the init.

Re: [Architecture] [APIM] Support for API Products from API Controller

2020-04-30 Thread Bhathiya Jayasekara
It would have been ideal if we had the commands in this format. *apictl * eg. apictl list apis apictl list api-products apictl create api apictl create api-product apictl delete api apictl delete api-product But I don't think we are now in a position to change it. Thanks, Bhathiya On Thu, Apr