Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-12 Thread Eric B
Yes - I'm building with JDK 1.8. If it is helpful, I can try to put together a POC to demonstrate the issue, but not sure how easy that will be to do. I suspect (although not sure why) that AJ is failing might have something to do with running the entire build with the -noverify flag (so the clas

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-12 Thread Andy Clement
You are only able to turn off the stackmap generation if targeting 1.6 because that is the level where they were optional. (-Xset:generateStackMaps=false) at targets 1.7 and above your error indicates this code is failing: *try* { Class reader = Class.forName("aj.org.objectweb.asm.ClassReader");

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-10 Thread Eric B
Thanks Andy! I'll take a look into this and see if I can leverage it for my own use case. Also, please let me know if the Error that I am seeing is a bug in AJ, or expected behaviour. Do you need me to open a ticket for that? Thanks, Eric On Tue, Oct 10, 2017 at 3:34 PM, Andy Clement wrote:

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-10 Thread Andy Clement
The very basic visitor AspectJ uses is here: https://github.com/eclipse/org.aspectj/blob/6d6738cfece6328027916681e67e54225531db38/weaver/src/org/aspectj/weaver/bcel/asm/StackMapAdder.java cheers, Andy On 10 October 2017 at 12:32, Andy Clement wrote: > Hey Eric, > > The error above is saying it

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-10 Thread Andy Clement
Hey Eric, The error above is saying it can't find the asm rather than that there is an issue with missing stack maps. Although possibly the error is occurring because as a side effect of the missing stack maps, I'd need to check. > Are there libraries to manipulate/generate a stackmap? This is e

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-09 Thread Eric B
In the last couple of days, I've been trying to read up on ASM, ClassWriter, ClassReader, Visitors (and Visitor pattern), etc. And although I'm understanding more about how these things work, I'm still a little bit at a loss how to write a simple ClassReader and rewrite it with a proper stackmap.

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-08 Thread Brett Randall
Maybe if you can post your POMs some Maven guru can help you out. On 7 October 2017 at 06:55, Eric B wrote: > I'm running into a problem with AspectJ 1.8.10, and not sure how to > resolve this. > > I have a multi-module maven build. One of my modules requires running an > ant task (using the an

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-08 Thread Alexander Kriegisch
I do hope that someone can help you with that, Eric. But just in case nobody can, I think a software developer should always strive to improve the status quo and always have a plan B. Having said that, I think that a JDO lib from 2004 sounds like a good reason to either upgrade it or get rid of

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-07 Thread Eric B
While I don't disagree with your answer, I dont have the first clue how to fix a legacy jdo library (circa 2004) that performs byte enhancement and does not write the stackmap.Are there libraries to manipulate/generate a stackmap? Is there anything else can I do in the meantime to unblock the

Re: [aspectj-users] Missing stackmap generation for woven code

2017-10-06 Thread Alexander Kriegisch
I know that this is not the answer you are looking for, but my suggestion is to heal the illness instead of taking pills against its symptoms. Go fix your problem in the other module which requires noverify in the first place. Generating broken bytecode does not sound like a wise approach to me.

[aspectj-users] Missing stackmap generation for woven code

2017-10-06 Thread Eric B
I'm running into a problem with AspectJ 1.8.10, and not sure how to resolve this. I have a multi-module maven build. One of my modules requires running an ant task (using the antrun-maven-plugin) with the jvm -noverify flag. Consequently, I run the entire maven build using the -noverify flag. Ho