Re: [asterisk-dev] WebRTC over SRTP-DTLS

2013-12-11 Thread Lorenzo Miniero
Just FYI, I published the whole patch here: https://issues.asterisk.org/jira/browse/ASTERISK-22961?focusedCommentId=212829page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-212829 As explained there, I didn't test it but it should work fine. Lorenzo 2013/12/4

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

2013-12-11 Thread Tzafrir Cohen
On Dec. 10, 2013, 5:14 p.m., rmudgett wrote: I don't think changing this default is a good idea. Enabling it is only useful if you are using the relative channel format. I have yet to see anyone on the Asterisk users list actually use this format. Tzafrir Cohen wrote:

Re: [asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3048/ --- (Updated Dec. 11, 2013, 12:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/ --- (Updated Dec. 11, 2013, 1:09 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3034: Tests for PJSIP_ENDPOINT

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3034/ --- (Updated Dec. 11, 2013, 1:22 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3037: Add tests for CHANNEL function for PJSIP

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3037/ --- (Updated Dec. 11, 2013, 1:21 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3038/ --- (Updated Dec. 11, 2013, 1:22 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3064: realtime: Create extensions in alembic ast-db-manage contribution

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3064/#review10381 --- Ship it! Ship It! - Matt Jordan On Dec. 10, 2013, 5:21

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

2013-12-11 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/ --- (Updated Dec. 11, 2013, 9:31 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2013-12-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3050/#review10382 --- /trunk/res/res_pjsip_registrar.c

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/#review10383 --- Richard asked me to take a look at this and limit my review to

[asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload

2013-12-11 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/ --- Review request for Asterisk Developers. Bugs: ASTERISK-19454

Re: [asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/#review10384 --- Ship it! Ship It! - Matt Jordan On Dec. 11, 2013, 12:16

Re: [asterisk-dev] [Code Review] 3050: PJSIP: Add Path header support

2013-12-11 Thread Mark Michelson
On Dec. 11, 2013, 3:22 p.m., Matt Jordan wrote: /trunk/res/res_pjsip_path.c, lines 105-126 https://reviewboard.asterisk.org/r/3050/diff/1/?file=49103#file49103line105 Because this is using an ao2_callback to get the contact, it's going to be rather expensive. If we were searching

Re: [asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload

2013-12-11 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/ --- (Updated Dec. 11, 2013, 7:19 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-11 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/ --- (Updated Dec. 11, 2013, 2:31 p.m.) Status -- This change has been

Re: [asterisk-dev] Asterisk 11 from Ubuntu Repos

2013-12-11 Thread Rusty Newton
On Tue, Dec 10, 2013 at 9:30 AM, Pablo Carranza pa...@vdevices.com wrote: Is it possible to install Asterisk 11 via the Ubuntu 12.04 repos? Is a PPA needed? If so, which one is recommended? I don't think so. At this time Digium doesn't currently maintain any current Debian or Ubuntu packages.

Re: [asterisk-dev] [Code Review] 3040: bridge transfers: Make sure ATTENDEDTRANSFER variable gets set for all the expected channels when doing bridge attended transfers. Also make sure BLINDTRANSFER i

2013-12-11 Thread Jonathan Rose
On Dec. 9, 2013, 11 p.m., rmudgett wrote: /branches/12/include/asterisk/bridge.h, lines 965-968 https://reviewboard.asterisk.org/r/3040/diff/2/?file=48994#file48994line965 Suggest changing the attended parameter name to imply that it is a boolean value: is_attended. change'd

Re: [asterisk-dev] [Code Review] 3040: bridge transfers: Make sure ATTENDEDTRANSFER variable gets set for all the expected channels when doing bridge attended transfers. Also make sure BLINDTRANSFER i

2013-12-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3040/ --- (Updated Dec. 11, 2013, 10:58 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3040: bridge transfers: Make sure ATTENDEDTRANSFER variable gets set for all the expected channels when doing bridge attended transfers. Also make sure BLINDTRANSFER i

2013-12-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3040/#review10389 --- Ship it! Ship It! - rmudgett On Dec. 11, 2013, 10:58 p.m.,

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/#review10388 --- Ship it! Heh, every time I thought I spotted something wrong,

Re: [asterisk-dev] Asterisk 11 from Ubuntu Repos

2013-12-11 Thread Paul Belanger
On 13-12-10 10:30 AM, Pablo Carranza wrote: Is it possible to install Asterisk 11 via the Ubuntu 12.04 repos? Is a PPA needed? If so, which one is recommended? I plan to do some work on it over the Christmas break. I'll likely publish them to a PPA on launchpad.net. -- Paul Belanger |