Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread jcollie
> On Jan. 2, 2014, 2:42 p.m., Russell Bryant wrote: > > I'm not sure this belongs in Asterisk itself, personally. > > > > In any case, Fedora has had a systemd unit for Asterisk for quite some > > time. For reference, you can view it here: > > http://pkgs.fedoraproject.org/cgit/asterisk.git/

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread jcollie
> On Jan. 1, 2014, 4:43 p.m., George Joseph wrote: > > /trunk/contrib/asterisk.service, line 20 > > > > > > I use the following which mimic some of the safe_asterisk settings... > > > > Nice=0 > > UMask=

Re: [asterisk-dev] [Code Review] 3100: pjsip sample config: document that AOR record name must match username

2014-01-02 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3100/ --- (Updated Jan. 2, 2014, 4:28 p.m.) Status -- This change has been disc

[asterisk-dev] [Code Review] 3100: pjsip sample config: document that AOR record name must match username

2014-01-02 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3100/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

2014-01-02 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3063/ --- (Updated Jan. 2, 2014, 2:26 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3083: funcs: REPLACE() can call strcpy on overlapping memory

2014-01-02 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3083/ --- (Updated Jan. 2, 2014, 2:25 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3095: chan_pjsip: add 'set_var' support on endpoints

2014-01-02 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3095/ --- (Updated Jan. 2, 2014, 1:14 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3097: Testsuite - chan_pjsip: add 'set_var' support on endpoints

2014-01-02 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3097/ --- (Updated Jan. 2, 2014, 1:15 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3083: funcs: REPLACE() can call strcpy on overlapping memory

2014-01-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3083/#review10508 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 2:02 p.m.

Re: [asterisk-dev] [Code Review] 3098: compiler warnings

2014-01-02 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3098/#review10507 --- Ship it! Ship It! - rmudgett On Jan. 2, 2014, 6:51 p.m., Ke

Re: [asterisk-dev] [Code Review] 3098: compiler warnings

2014-01-02 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3098/ --- (Updated Jan. 2, 2014, 12:51 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] Asterisk 12 trunk setup

2014-01-02 Thread Mark Michelson
Kilburn Abrahams Tuesday, December 31, 2013 5:31 PM HiI am testing Asterisk 12 and got most things working, but cannot get a trunk setup working correctly with the pjsip channel driver. The provider provides IP security so no registering or credentials are required. It

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062/#review10506 --- I'm not sure this belongs in Asterisk itself, personally. In a

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread Tzafrir Cohen
> On Jan. 1, 2014, 1:41 a.m., Matt Jordan wrote: > > /trunk/contrib/asterisk.service, line 12 > > > > > > Looking at how safe_asterisk spawns Asterisk, I'm not sure specifying > > an explicit run user is appropriate

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread Tzafrir Cohen
On Wed, Jan 01, 2014 at 05:16:42PM -0700, George Joseph wrote: > On Wed, Jan 1, 2014 at 4:31 PM, Oron Peled wrote: > > > > > On Wednesday 01 January 2014 10:23:01 Tzafrir Cohen wrote: > > > I looked into running Asterisk as non-root. But I can't find a way > > > to get systemd to generate /var/ru

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-02 Thread Tzafrir Cohen
On Thu, Jan 02, 2014 at 01:31:26AM +0200, Oron Peled wrote: > > On Wednesday 01 January 2014 10:23:01 Tzafrir Cohen wrote: > > I looked into running Asterisk as non-root. But I can't find a way > > to get systemd to generate /var/run/asterisk as a writable directory to > > the service. > > I thin